From b64389d8408b876914acee4ecdeb54929f2ae8ef Mon Sep 17 00:00:00 2001 From: Aaron Durbin Date: Fri, 2 Sep 2016 17:25:35 -0500 Subject: [PATCH] mainboard/google/reef: declare mainboard_ec_init() in each C file There's no common EC header file in the code base, and I didn't want to use a header file for single declaration. Therefore, just move the declaration to each file that uses that symbol. BUG=chrome-os-partner:56677 Change-Id: Ibaebb0ea6a07029aec02d5185cf05ffb8593b117 Signed-off-by: Aaron Durbin Reviewed-on: https://review.coreboot.org/16420 Tested-by: build bot (Jenkins) Reviewed-by: Duncan Laurie --- src/mainboard/google/reef/bootblock.c | 2 ++ src/mainboard/google/reef/ec.c | 2 ++ src/mainboard/google/reef/mainboard.c | 2 ++ .../google/reef/variants/baseboard/include/baseboard/ec.h | 4 ---- 4 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/mainboard/google/reef/bootblock.c b/src/mainboard/google/reef/bootblock.c index ab010e2d39..da66009834 100644 --- a/src/mainboard/google/reef/bootblock.c +++ b/src/mainboard/google/reef/bootblock.c @@ -19,6 +19,8 @@ #include #include +void mainboard_ec_init(void); + void bootblock_mainboard_init(void) { const struct pad_config *pads; diff --git a/src/mainboard/google/reef/ec.c b/src/mainboard/google/reef/ec.c index 612708ec5c..e1832fdbaf 100644 --- a/src/mainboard/google/reef/ec.c +++ b/src/mainboard/google/reef/ec.c @@ -20,6 +20,8 @@ #include #include +void mainboard_ec_init(void); + static void ramstage_ec_init(void) { printk(BIOS_ERR, "mainboard: EC init\n"); diff --git a/src/mainboard/google/reef/mainboard.c b/src/mainboard/google/reef/mainboard.c index 7d5a7e19c4..a2421df1e6 100644 --- a/src/mainboard/google/reef/mainboard.c +++ b/src/mainboard/google/reef/mainboard.c @@ -25,6 +25,8 @@ #include #include +void mainboard_ec_init(void); + static void mainboard_init(void *chip_info) { int boardid; diff --git a/src/mainboard/google/reef/variants/baseboard/include/baseboard/ec.h b/src/mainboard/google/reef/variants/baseboard/include/baseboard/ec.h index 7763630715..5c8e306a64 100644 --- a/src/mainboard/google/reef/variants/baseboard/include/baseboard/ec.h +++ b/src/mainboard/google/reef/variants/baseboard/include/baseboard/ec.h @@ -70,8 +70,4 @@ EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY_SHUTDOWN)|\ EC_HOST_EVENT_MASK(EC_HOST_EVENT_PANIC)) -#ifndef __ACPI__ -extern void mainboard_ec_init(void); -#endif - #endif