GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/siemens/mc_ehl4: Change GPIO GPP_B5 polarity for DRAM population 

With the latest hardware revision, the polarity of GPP_B5 has been
changed. For a full-populated DRAM configuration, the input signal is
now connected to 3.3 V and for a half-populated configuration it is
connected to ground.

BUG=none
TEST=Use different populated mainboards and check coreboot log

GPP_B5 = 0:
[INFO ]  meminit_channels: DRAM half-populated
[DEBUG]  1 DIMMs found

GPP_B5 = 1:
[DEBUG]  2 DIMMs found

Change-Id: Iaa3a63fa52c802d8f5d8c6cc11dd6edfac117e88
Signed-off-by: Mario Scheithauer <mario.scheithauer@siemens.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/76434
Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
Reviewed-by: Jan Samek <jan.samek@siemens.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Mario Scheithauer 2023-07-12 13:39:54 +02:00 committed by Werner Zeh
parent 7ecc366470
commit b6940dfdae
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/mainboard/siemens/mc_ehl/variants/mc_ehl4/memory.c
View File

@ -63,5 +63,5 @@ bool half_populated(void)
/* There are two different memory expansion variants of this mainboard. /* There are two different memory expansion variants of this mainboard.
The GPIO GPP_B5 indicates whether the mainboard is equipped with half- or The GPIO GPP_B5 indicates whether the mainboard is equipped with half- or
full-populated DRAM. */ full-populated DRAM. */
return gpio_get(GPP_B5); return !gpio_get(GPP_B5);
} }