GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

payloads/coreinfo: Free buffer before returning 

This fixes a memory leak, which was partially resolved in
2d1e0eb (payloads/coreinfo: Free buffer before returning).

Found-by: Coverity Scan, CID 1373370 (RESOURCE_LEAK)
Signed-off-by: Jacob Garber <jgarber1@ualberta.ca>
Change-Id: I0efe94b9dfb27746828055427029c01c7f407ec2
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32094
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Patrick Rudolph <siro@das-labor.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Jacob Garber 2019-03-27 20:41:34 -06:00 committed by Patrick Georgi
parent 988ac294c7
commit b6d91753fc
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
payloads/coreinfo/timestamps_module.c
View File

@ -203,8 +203,10 @@ static int timestamps_module_init(void)
SCREEN_X, LINES_SHOWN); SCREEN_X, LINES_SHOWN);
/* Sanity check, chars_count must be padded to full line */ /* Sanity check, chars_count must be padded to full line */
if (chars_count % SCREEN_X != 0) if (chars_count % SCREEN_X != 0) {
free(buffer);
return -2; return -2;
}
g_lines_count = chars_count / SCREEN_X; g_lines_count = chars_count / SCREEN_X;
g_max_cursor_line = MAX(g_lines_count - 1 - LINES_SHOWN, 0); g_max_cursor_line = MAX(g_lines_count - 1 - LINES_SHOWN, 0);