GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

xgcc: fix grouping of conditions in buildgcc for Ada 

No idea where the escaped parentheses come from but they
are no good. Without this patch I see errors with bash and dash:
  ./buildgcc: line 1198: (: command not found
  ./buildgcc: line 1199: (: command not found

The patch uses curly brackets for grouping since they don't
launch a subshell - unlike using unescaped parentheses which
would work too.
shellcheck is happy with either variant (and the original one(!)).

Change-Id: I44fbc659f5b54515e43e85680b1ab0a824b781a7
Signed-off-by: Stefan Tauner <stefan.tauner@gmx.at>
Reviewed-on: https://review.coreboot.org/27771
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-by: Nico Huber <nico.h@gmx.de>
This commit is contained in:
Stefan Tauner 2018-08-01 06:57:36 +02:00 committed by Nico Huber
parent eceba31c7f
commit b75a08b199
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
util/crossgcc/buildgcc
View File

@ -1195,9 +1195,9 @@ fi
if ada_requested; then if ada_requested; then
if have_gnat; then if have_gnat; then
if [ "$BOOTSTRAP" != 1 ] && \ if [ "$BOOTSTRAP" != 1 ] && \
\( [ "$(hostcc_major)" -lt 4 ] || \ { [ "$(hostcc_major)" -lt 4 ] || \
\( [ "$(hostcc_major)" -eq 4 ] && \ { [ "$(hostcc_major)" -eq 4 ] && \
[ "$(hostcc_minor)" -lt 9 ] \) \) ] [ "$(hostcc_minor)" -lt 9 ] ; } ; }
then then
printf "\n${red}WARNING${NC}\n" printf "\n${red}WARNING${NC}\n"
printf "Building the Ada compiler (GNAT $(buildcc_version)) with a host compiler older\n" printf "Building the Ada compiler (GNAT $(buildcc_version)) with a host compiler older\n"