GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/mediatek/mt8186: Reduce GPIO code size in bootblock 

Create a new GPIO driving info table that contains only the pins used
in the bootblock. The GPIO driving info table is downsized from 1480
bytes to 24 bytes.

BUG=b:270911452
TEST=build pass

Change-Id: I24775ba93cd74ae401747c2f5a26bbf1c8f6ac0a
Signed-off-by: Jason Chen <Jason-ch.Chen@mediatek.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/74062
Reviewed-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
Reviewed-by: Yu-Ping Wu <yupingso@google.com>
Reviewed-by: Yidi Lin <yidilin@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Jason Chen 2023-03-28 15:41:38 +08:00 committed by Rex-BC Chen
parent 9fbdb2b192
commit b75c92fa26
3 changed files with 105 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/soc/mediatek/common/include/soc/gpio_common.h
View File

@ -34,7 +34,7 @@ enum gpio_drv_adv {
};
struct gpio_drv_info {
uint32_t offset;
uint8_t offset;
uint8_t shift;
uint8_t width;
};

112
src/soc/mediatek/mt8186/gpio.c
View File

@ -5,9 +5,34 @@
* Chapter number: 5.1
*/
#include <assert.h>
#include <device/mmio.h>
#include <gpio.h>
enum {
SPI0_CLK_A = 0,
SPI0_CSB_A = 1,
SPI0_MO_A = 2,
SPI0_MI_A = 3,
TDM_RX_BCK = 4,
TDM_RX_MCLK = 5,
TDM_RX_DATA0 = 6,
TDM_RX_DATA1 = 7,
};
static const struct gpio_drv_info bootblock_gpio_driving_info[] = {
/* GPIO 36~39 */
[SPI0_CLK_A] = { 0x0, 9, 3, },
[SPI0_CSB_A] = { 0x0, 9, 3, },
[SPI0_MO_A] = { 0x0, 12, 3, },
[SPI0_MI_A] = { 0x0, 9, 3, },
/* GPIO 61~64 */
[TDM_RX_BCK] = { 0x0, 24, 3, },
[TDM_RX_MCLK] = { 0x0, 24, 3, },
[TDM_RX_DATA0] = { 0x0, 24, 3, },
[TDM_RX_DATA1] = { 0x0, 27, 3, },
};
static const struct gpio_drv_info gpio_driving_info[] = {
[0] = { 0x0, 27, 3, },
[1] = { 0x0, 27, 3, },
@ -253,6 +278,60 @@ void *gpio_find_reg_addr(gpio_t gpio)
return reg_addr;
}
static const struct gpio_drv_info *get_gpio_driving_info(uint32_t raw_id)
{
if (ENV_BOOTBLOCK) {
uint32_t id;
switch (raw_id) {
case GPIO_ID(SPI0_CLK):
id = SPI0_CLK_A;
break;
case GPIO_ID(SPI0_CSB):
id = SPI0_CSB_A;
break;
case GPIO_ID(SPI0_MO):
id = SPI0_MO_A;
break;
case GPIO_ID(SPI0_MI):
id = SPI0_MI_A;
break;
case GPIO_ID(TDM_RX_BCK):
id = TDM_RX_BCK;
break;
case GPIO_ID(TDM_RX_MCLK):
id = TDM_RX_MCLK;
break;
case GPIO_ID(TDM_RX_DATA0):
id = TDM_RX_DATA0;
break;
case GPIO_ID(TDM_RX_DATA1):
id = TDM_RX_DATA1;
break;
default:
return NULL;
}
assert(id < ARRAY_SIZE(bootblock_gpio_driving_info));
return &bootblock_gpio_driving_info[id];
} else {
if (raw_id >= ARRAY_SIZE(gpio_driving_info))
return NULL;
return &gpio_driving_info[raw_id];
}
}
static const struct gpio_drv_info *get_gpio_driving_adv_info(uint32_t raw_id)
{
if (ENV_BOOTBLOCK) {
return NULL;
} else {
if (raw_id >= ARRAY_SIZE(gpio_driving_adv_info))
return NULL;
return &gpio_driving_adv_info[raw_id];
}
}
static inline bool is_valid_drv(uint8_t drv)
{
return drv <= GPIO_DRV_16_MA;
@ -266,16 +345,16 @@ static inline bool is_valid_drv_adv(enum gpio_drv_adv drv)
int gpio_set_driving(gpio_t gpio, uint8_t drv)
{
uint32_t mask;
const struct gpio_drv_info *info = &gpio_driving_info[gpio.id];
const struct gpio_drv_info *adv_info = &gpio_driving_adv_info[gpio.id];
void *reg, *reg_adv;
const struct gpio_drv_info *info = get_gpio_driving_info(gpio.id);
const struct gpio_drv_info *adv_info = get_gpio_driving_adv_info(gpio.id);
void *reg, *reg_adv, *reg_addr;
if (!info)
return -1;
if (!is_valid_drv(drv))
return -1;
reg = gpio_find_reg_addr(gpio) + info->offset;
reg_adv = gpio_find_reg_addr(gpio) + adv_info->offset;
if (info->width == 0)
return -1;
@ -284,20 +363,27 @@ int gpio_set_driving(gpio_t gpio, uint8_t drv)
if ((uint32_t)drv > mask)
return -1;
reg_addr = gpio_find_reg_addr(gpio);
reg = reg_addr + info->offset;
clrsetbits32(reg, mask << info->shift, drv << info->shift);
/* Disable EH if supported */
if (adv_info->width != 0)
if (adv_info && adv_info->width != 0) {
reg_adv = reg_addr + adv_info->offset;
clrbits32(reg_adv, BIT(adv_info->shift));
}
return 0;
}
int gpio_get_driving(gpio_t gpio)
{
const struct gpio_drv_info *info = &gpio_driving_info[gpio.id];
const struct gpio_drv_info *info = get_gpio_driving_info(gpio.id);
void *reg;
if (!info)
return -1;
reg = gpio_find_reg_addr(gpio) + info->offset;
if (info->width == 0)
return -1;
@ -308,9 +394,12 @@ int gpio_get_driving(gpio_t gpio)
int gpio_set_driving_adv(gpio_t gpio, enum gpio_drv_adv drv)
{
uint32_t mask;
const struct gpio_drv_info *adv_info = &gpio_driving_adv_info[gpio.id];
const struct gpio_drv_info *adv_info = get_gpio_driving_adv_info(gpio.id);
void *reg_adv;
if (!adv_info)
return -1;
if (!is_valid_drv_adv(drv))
return -1;
@ -334,10 +423,13 @@ int gpio_set_driving_adv(gpio_t gpio, enum gpio_drv_adv drv)
int gpio_get_driving_adv(gpio_t gpio)
{
const struct gpio_drv_info *adv_info = &gpio_driving_adv_info[gpio.id];
const struct gpio_drv_info *adv_info = get_gpio_driving_adv_info(gpio.id);
void *reg_adv;
uint32_t drv;
if (!adv_info)
return -1;
reg_adv = gpio_find_reg_addr(gpio) + adv_info->offset;
if (adv_info->width == 0)
return -1;

2
src/soc/mediatek/mt8186/include/soc/gpio.h
View File

@ -31,6 +31,8 @@ enum gpio_drv {
GPIO_DRV_16_MA = 7,
};
#define GPIO_ID(name) PAD_##name##_ID
#define PIN(id, name, flag, bit, base, offset, \
func1, func2, func3, func4, func5, func6, func7) \
PAD_##name##_ID = id, \