From b81ad9c6b15fc27047d6f5906e5909f77f0440df Mon Sep 17 00:00:00 2001 From: Tarun Tuli Date: Tue, 15 Nov 2022 16:32:30 +0000 Subject: [PATCH] mb/google/brya/acpi: Update NVPCF_FUNC_UPDATE_DYNAMIC_PARAMS 1) Update location of TGP (MAGA) to Params2[15:0] 2) Add TPPA (value of 25W) Package: ... Case (0x02) { Local0 = Buffer (0x31) { 0x22, 0x05, 0x10, 0x1C, 0x01 } CreateWordField (Local0, 0x1D, MAGA) CreateWordField (Local0, 0x19, TPPA) CreateDWordField (Local0, 0x15, CEO0) MAGA = 0x50 TPPA = 0xC8 CEO0 = 0x0200 Return (Local0) } ... BUG=b:214581372 TEST=build and verify DSDT on device Signed-off-by: Tarun Tuli Change-Id: I69b80f4af2ecef6cf91034fc15fb6e8715eeca4f Reviewed-on: https://review.coreboot.org/c/coreboot/+/69639 Reviewed-by: Subrata Banik Reviewed-by: Nick Vaccaro Reviewed-by: Kapil Porwal Reviewed-by: Eric Lai Tested-by: build bot (Jenkins) --- src/mainboard/google/brya/acpi/nvpcf.asl | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/mainboard/google/brya/acpi/nvpcf.asl b/src/mainboard/google/brya/acpi/nvpcf.asl index 019a5c1742..f6a5c075fc 100644 --- a/src/mainboard/google/brya/acpi/nvpcf.asl +++ b/src/mainboard/google/brya/acpi/nvpcf.asl @@ -50,10 +50,12 @@ Method (NPCF, 2, Serialized) /* Dynamic Params Table Header (1 controller entry, 0x1c bytes) */ 0x22, 0x05, 0x10, 0x1c, 0x01 } - CreateWordField (Local0, 0x05, TGPA) + CreateWordField (Local0, 0x1d, MAGA) + CreateWordField (Local0, 0x19, TPPA) CreateDWordField (Local0, 0x15, CEO0) - TGPA = 0x50 /* TGP on AC = 10W in 1/8-Watt increments */ + MAGA = 0x50 /* TGP on AC = 10W in 1/8-Watt increments */ + TPPA = 0xc8 /* TPPA = 25W in 1/8-Watt increments */ CEO0 = 0x200 /* [7:0] Controller index [8:8] Disable controller on AC [9:9] Disable controller on DC */