GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/skylake/vr_config: Use lookup table by default 

If the board doesn't provide VRconfig in devicetree make sure to use
the lookup table for IccMax instead of defaults for some mobile SoC.

Also use decimal values instead of hex.

Change-Id: If31063f9b483a3bbd6cc90df1c1b76b4efc66445
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/37598
Reviewed-by: Maxim Polyakov <max.senia.poliak@gmail.com>
Reviewed-by: Michael Niewöhner
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Patrick Rudolph 2019-12-09 08:56:39 +01:00 committed by Patrick Rudolph
parent d33b02e7f3
commit b824f7dbae
1 changed files with 13 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
src/soc/intel/skylake/vr_config.c
View File

@ -31,9 +31,9 @@ static const struct vr_config default_configs[NUM_VR_DOMAINS] = {
.psi3threshold = VR_CFG_AMP(1), .psi3threshold = VR_CFG_AMP(1),
.psi3enable = 0, .psi3enable = 0,
.psi4enable = 0, .psi4enable = 0,
.imon_slope = 0x0, .imon_slope = 0,
.imon_offset = 0x0, .imon_offset = 0,
.icc_max = VR_CFG_AMP(7), .icc_max = 0,
.voltage_limit = 1520, .voltage_limit = 1520,
}, },
[VR_IA_CORE] = { [VR_IA_CORE] = {
@ -43,9 +43,9 @@ static const struct vr_config default_configs[NUM_VR_DOMAINS] = {
.psi3threshold = VR_CFG_AMP(1), .psi3threshold = VR_CFG_AMP(1),
.psi3enable = 0, .psi3enable = 0,
.psi4enable = 0, .psi4enable = 0,
.imon_slope = 0x0, .imon_slope = 0,
.imon_offset = 0x0, .imon_offset = 0,
.icc_max = VR_CFG_AMP(34), .icc_max = 0,
.voltage_limit = 1520, .voltage_limit = 1520,
}, },
[VR_GT_UNSLICED] = { [VR_GT_UNSLICED] = {
@ -55,9 +55,9 @@ static const struct vr_config default_configs[NUM_VR_DOMAINS] = {
.psi3threshold = VR_CFG_AMP(1), .psi3threshold = VR_CFG_AMP(1),
.psi3enable = 0, .psi3enable = 0,
.psi4enable = 0, .psi4enable = 0,
.imon_slope = 0x0, .imon_slope = 0,
.imon_offset = 0x0, .imon_offset = 0,
.icc_max = VR_CFG_AMP(35), .icc_max = 0,
.voltage_limit = 1520, .voltage_limit = 1520,
}, },
[VR_GT_SLICED] = { [VR_GT_SLICED] = {
@ -67,9 +67,9 @@ static const struct vr_config default_configs[NUM_VR_DOMAINS] = {
.psi3threshold = VR_CFG_AMP(1), .psi3threshold = VR_CFG_AMP(1),
.psi3enable = 0, .psi3enable = 0,
.psi4enable = 0, .psi4enable = 0,
.imon_slope = 0x0, .imon_slope = 0,
.imon_offset = 0x0, .imon_offset = 0,
.icc_max = VR_CFG_AMP(35), .icc_max = 0,
.voltage_limit = 1520, .voltage_limit = 1520,
}, },
}; };
@ -334,6 +334,7 @@ void fill_vr_domain_config(void *params,
vr_params->Psi4Enable[domain] = cfg->psi4enable; vr_params->Psi4Enable[domain] = cfg->psi4enable;
vr_params->ImonSlope[domain] = cfg->imon_slope; vr_params->ImonSlope[domain] = cfg->imon_slope;
vr_params->ImonOffset[domain] = cfg->imon_offset; vr_params->ImonOffset[domain] = cfg->imon_offset;
/* If board provided non-zero value, use it. */ /* If board provided non-zero value, use it. */
if (cfg->icc_max) if (cfg->icc_max)
vr_params->IccMax[domain] = cfg->icc_max; vr_params->IccMax[domain] = cfg->icc_max;