GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

lib/reg_script.c: Remove unused assignment 

Fix the warning below.

```
    CC         bootblock/lib/reg_script.o
src/lib/reg_script.c:375:11: warning: Value stored to 'value' during its \
initialization is never read
        uint64_t value = msr.hi;
                 ^~~~~   ~~~~~~
```

Found-by: Clang static analyzer scan-build
          (clang version 4.0.1-6 (tags/RELEASE_401/final))
Fixes: fd461e39 (regscript: Add support for MSR type)
Change-Id: I218e45d12f2f00e2ad4cfe5410029f407b57568d
Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
Reviewed-on: https://review.coreboot.org/22197
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Duncan Laurie <dlaurie@chromium.org>
This commit is contained in:
Paul Menzel 2017-10-27 10:58:00 +02:00 committed by Nico Huber
parent 57ea9b41e7
commit b843c5e3f3
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/lib/reg_script.c
View File

@ -373,7 +373,6 @@ static uint64_t reg_script_read_msr(struct reg_script_context *ctx)
const struct reg_script *step = reg_script_get_step(ctx); const struct reg_script *step = reg_script_get_step(ctx);
msr_t msr = rdmsr(step->reg); msr_t msr = rdmsr(step->reg);
uint64_t value = msr.hi; uint64_t value = msr.hi;
value = msr.hi;
value <<= 32; value <<= 32;
value |= msr.lo; value |= msr.lo;
return value; return value;