GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/common: Do not trigger crashlog on all resets by default 

Crashlog has error records and PMC reset records two parts. When we
send ipc cmd "PMC_IPC_CMD_ID_CRASHLOG_ON_RESET", PMC reset record is
enabled. At each warm/cold/global reset, crashlog would be triggered.
The cause of this crash would be "TRIGGER_ON_ALL_RESETS", it is used to
catch unknown reset reason. At the same time, we would see [Hardware
Error] in the kernel log.

If we default enable TRIGGER_ON_ALL_RESETS, we would have too many false
alarm. Now we disable PMC reset records part by default. And we could
enable it when we need it for the debug purpose.

The generated bert dump is under /var/spool/crash/, we could check this
path to verify this CONFIG disable/enable status.

BUG=b:202737385
TEST=No new bert dump after a warm reset.

Signed-off-by: Curtis Chen <curtis.chen@intel.com>
Change-Id: I3ec4ff3c8a3799156de030f4556fe6ce61305139
Reviewed-on: https://review.coreboot.org/c/coreboot/+/59951
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
This commit is contained in:
Curtis Chen 2021-12-07 18:01:57 +08:00 committed by Felix Held
parent b39f2a9066
commit b89c798ddc
4 changed files with 18 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/soc/intel/alderlake/Kconfig
View File

@ -333,13 +333,6 @@ config MRC_CHANNEL_WIDTH
int int
default 16 default 16
config SOC_INTEL_CRASHLOG
def_bool n
select SOC_INTEL_COMMON_BLOCK_CRASHLOG
select ACPI_BERT
help
Enables CrashLog.
config ACPI_ADL_IPU_ES_SUPPORT config ACPI_ADL_IPU_ES_SUPPORT
def_bool n def_bool n
help help

14
src/soc/intel/common/Kconfig.common
View File

@ -79,4 +79,18 @@ config SMM_MODULE_STACK_SIZE
hex hex
default 0x800 default 0x800
config SOC_INTEL_CRASHLOG
def_bool n
select SOC_INTEL_COMMON_BLOCK_CRASHLOG
select ACPI_BERT
help
Enables Crashlog.
config SOC_INTEL_CRASHLOG_ON_RESET
def_bool n
help
Enables the PMC to collect crashlog records on every reset event. NOTE:
This will result in a BERT table being populated containing a PMC
crashlog record on every boot.
endif # SOC_INTEL_COMMON endif # SOC_INTEL_COMMON

6
src/soc/intel/common/block/crashlog/crashlog.c
View File

@ -479,8 +479,10 @@ void collect_pmc_and_cpu_crashlog_from_srams(void)
{ {
if (pmc_crashlog_support() && cl_pmc_data_present() if (pmc_crashlog_support() && cl_pmc_data_present()
&& (cl_get_pmc_record_size() > 0)) { && (cl_get_pmc_record_size() > 0)) {
cl_pmc_en_gen_on_all_reboot(); if (CONFIG(SOC_INTEL_CRASHLOG_ON_RESET)) {
printk(BIOS_DEBUG, "Crashlog collection enabled on every reboot.\n"); cl_pmc_en_gen_on_all_reboot();
printk(BIOS_DEBUG, "Crashlog collection enabled on every reboot.\n");
}
cl_get_pmc_sram_data(); cl_get_pmc_sram_data();
} else { } else {
printk(BIOS_DEBUG, "Skipping PMC crashLog collection. Data not present.\n"); printk(BIOS_DEBUG, "Skipping PMC crashLog collection. Data not present.\n");

7
src/soc/intel/tigerlake/Kconfig
View File

@ -284,13 +284,6 @@ config MRC_CHANNEL_WIDTH
int int
default 16 default 16
config SOC_INTEL_CRASHLOG
def_bool n
select SOC_INTEL_COMMON_BLOCK_CRASHLOG
select ACPI_BERT
help
Enables CrashLog.
# Intel recommends reserving the following resources per USB4 root port, # Intel recommends reserving the following resources per USB4 root port,
# from TGL BIOS Spec (doc #611569) Revision 0.7.6 Section 7.2.5.1.5 # from TGL BIOS Spec (doc #611569) Revision 0.7.6 Section 7.2.5.1.5
# - 42 buses # - 42 buses