GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd/common: Skip psp_verstage on S0i3 resume 

PSP_Verstage will take almost the entire time to run that
is allotted to S0i3 resume.  Since coreboot isn't running,
the PSP needs to handle any security requirements.  The long-
term plan is that the PSP won't even load psp_verstage on S0i3
resume, but when it is loaded, this makes sure we exit
immediately

BUG=b:177064859
TEST=Verify that PSP_verstage doesn't run on S0i3 resume

Signed-off-by: Martin Roth <martinroth@chromium.org>
Change-Id: Ia7b2560ff3d7621922ec4bc0e8793961f5d7550f
Reviewed-on: https://review.coreboot.org/c/coreboot/+/56919
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Raul Rangel <rrangel@chromium.org>
This commit is contained in:
Martin Roth 2021-08-11 13:34:03 -06:00 committed by Felix Held
parent ad5b8b8ef9
commit b90e6fdd25
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/soc/amd/common/psp_verstage/psp_verstage.c
View File

@ -200,6 +200,16 @@ void Main(void)
{ {
uint32_t retval; uint32_t retval;
struct vb2_context *ctx = NULL; struct vb2_context *ctx = NULL;
uint32_t bootmode = 0;
/*
* Currently, we want to skip running verstage on all S0i3 resumes. This relies
* on an assumption that the PSP will be checksumming all of its components.
* TODO(b/196400450): Remove when PSP no longer loads verstage on S0i3 resume.
*/
svc_get_boot_mode(&bootmode);
if (bootmode == PSP_BOOT_MODE_S0i3_RESUME)
svc_exit(0);
/* /*
* Do not use printk() before console_init() * Do not use printk() before console_init()