GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/common: Rename compare_cse_version() function name 

The patch renames the compare_cse_version() function to the
cse_compare_sub_part_version(). It makes the function generic so that
it can be used to compare version of any CSE sub-partition like IOM,
NPHY etc.

TEST=Verified build for Brya

Signed-off-by: Sridhar Siricilla <sridhar.siricilla@intel.com>
Change-Id: I88a44a3c0ba2ad8a589602a35ea644dab535b287
Reviewed-on: https://review.coreboot.org/c/coreboot/+/59689
Reviewed-by: Krishna P Bhat D <krishna.p.bhat.d@intel.com>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Sridhar Siricilla 2021-11-27 13:57:40 +05:30 committed by Tim Wawrzynczak
parent 78c9b678d7
commit b9277bad50
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/soc/intel/common/block/cse/cse_lite.c
View File

@ -476,12 +476,13 @@ static const char *cse_get_source_rdev_fmap(void)
} }
/* /*
* Compare versions of CSE CBFS RW and CSE RW partition * Compare versions of CSE CBFS sub-component and CSE sub-component partition
* In case of CSE component comparison:
* If ver_cmp_status = 0, no update is required * If ver_cmp_status = 0, no update is required
* If ver_cmp_status < 0, coreboot downgrades CSE RW region * If ver_cmp_status < 0, coreboot downgrades CSE RW region
* If ver_cmp_status > 0, coreboot upgrades CSE RW region * If ver_cmp_status > 0, coreboot upgrades CSE RW region
*/ */
static int compare_cse_version(const struct fw_version *a, const struct fw_version *b) static int cse_compare_sub_part_version(const struct fw_version *a, const struct fw_version *b)
{ {
if (a->major != b->major) if (a->major != b->major)
return a->major - b->major; return a->major - b->major;
@ -590,7 +591,7 @@ static enum cse_update_status cse_check_update_status(const struct cse_bp_info *
cbfs_unmap(version_str); cbfs_unmap(version_str);
ret = compare_cse_version(&cbfs_rw_version, cse_get_rw_version(cse_bp_info)); ret = cse_compare_sub_part_version(&cbfs_rw_version, cse_get_rw_version(cse_bp_info));
if (ret == 0) if (ret == 0)
return CSE_UPDATE_NOT_REQUIRED; return CSE_UPDATE_NOT_REQUIRED;
else if (ret < 0) else if (ret < 0)