GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd/common/block/gpio_banks/gpio: add comment in check_gpios 

Each bit in the GPIO wake status index registers is set to 1 when at
least one of 4 corresponding GPIO pins has its wake status register set.
Added the comment since the gpio_base + i * 4 in the next line looked as
if it calculates some absolute register value which is not what the code
does or should be doing.

Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: I2fc8e9c5bd7c1b011f364b05d0cfdeb0df88ada6
Reviewed-on: https://review.coreboot.org/c/coreboot/+/56703
Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Felix Held 2021-07-30 02:58:19 +02:00
parent 75196bf6bb
commit b93a9a282f
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/soc/amd/common/block/gpio_banks/gpio.c
View File

@ -308,6 +308,7 @@ static void check_gpios(uint32_t wake_stat, int bit_limit, int gpio_base,
for (i = 0; i < bit_limit; i++) { for (i = 0; i < bit_limit; i++) {
if (!(wake_stat & BIT(i))) if (!(wake_stat & BIT(i)))
continue; continue;
/* Each wake status register bit is for 4 GPIOs that then will be checked */
begin = gpio_base + i * 4; begin = gpio_base + i * 4;
end = begin + 4; end = begin + 4;
/* There is no gpio 63. */ /* There is no gpio 63. */