GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/nissa/var/joxer: Remove VBOOT_GSC_BOARD_ID config 

Board IDs are now filled in as part of the signing process, so we don't
need to set them in coreboot.

BUG=b:240620735
TEST=Build and check VBOOT_GSC_BOARD_ID is set to ZZCR.

Change-Id: I7dda8ad59046a1dd9a28595e037eda86e91c98df
Signed-off-by: Reka Norman <rekanorman@chromium.org>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/75641
Reviewed-by: Himanshu Sahdev <himanshu.sahdev@intel.com>
Reviewed-by: Julius Werner <jwerner@chromium.org>
Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Reka Norman 2023-06-05 09:54:45 +10:00 committed by Felix Held
parent 8d9fb76c41
commit b9dd0371f1
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/mainboard/google/brya/Kconfig
View File

@ -292,10 +292,6 @@ config VBOOT
select VBOOT_EARLY_EC_SYNC if !BOARD_GOOGLE_BASEBOARD_NISSA select VBOOT_EARLY_EC_SYNC if !BOARD_GOOGLE_BASEBOARD_NISSA
select VBOOT_LID_SWITCH select VBOOT_LID_SWITCH
config VBOOT_GSC_BOARD_ID
string
default "LBTV" if BOARD_GOOGLE_JOXER
config DIMM_SPD_SIZE config DIMM_SPD_SIZE
default 512 default 512

2
src/security/vboot/Kconfig
View File

@ -336,6 +336,8 @@ config VBOOT_GSC_BOARD_ID
help help
GSC board ID to be embedded in the GSCVD. Usually each specific mainboard variant GSC board ID to be embedded in the GSCVD. Usually each specific mainboard variant
has its own. Google engineers can find these in the go/cros-dlm database ("Products"). has its own. Google engineers can find these in the go/cros-dlm database ("Products").
The specific board IDs are filled in as part of the production signing process, so
this value is just a default and doesn't need to be set per-variant in coreboot.
(Note: This is a completely separate thing from coreboot's `board_id()` function.) (Note: This is a completely separate thing from coreboot's `board_id()` function.)
menu "GBB configuration" menu "GBB configuration"