GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

arch/x86/postcar_loader.c: Reduce the scope of functions 

Some functions are only called locally.

Change-Id: I96a4e40a225536f62abb2a15c55d333b8604e8cc
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/61963
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Raul Rangel <rrangel@chromium.org>
This commit is contained in:
Arthur Heymans 2022-02-15 11:04:15 +01:00
parent 4e619b2c5c
commit ba00d10c41
2 changed files with 4 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/arch/x86/include/arch/romstage.h
View File

@ -20,12 +20,6 @@ struct postcar_frame {
struct var_mtrr_context *mtrr; struct var_mtrr_context *mtrr;
}; };
/*
* Initialize postcar_frame object.
* Returns 0 on success, < 0 on error.
*/
int postcar_frame_init(struct postcar_frame *pcf);
/* /*
* Add variable MTRR covering the provided range with MTRR type. * Add variable MTRR covering the provided range with MTRR type.
*/ */
@ -51,17 +45,6 @@ void fill_postcar_frame(struct postcar_frame *pcf);
*/ */
void prepare_and_run_postcar(struct postcar_frame *pcf); void prepare_and_run_postcar(struct postcar_frame *pcf);
/*
* Load and run a program that takes control of execution that
* tears down CAR and loads ramstage. The postcar_frame object
* indicates how to set up the frame. If caching is enabled at
* the time of the call it is up to the platform code to handle
* coherency with dirty lines in the cache using some mechanism
* such as platform_prog_run() because run_postcar_phase()
* utilizes prog_run() internally.
*/
void run_postcar_phase(struct postcar_frame *pcf);
/* /*
* Systems without a native coreboot cache-as-ram teardown may implement * Systems without a native coreboot cache-as-ram teardown may implement
* this to use an alternate method. * this to use an alternate method.

6
src/arch/x86/postcar_loader.c
View File

@ -19,7 +19,7 @@ static size_t var_mtrr_ctx_size(void)
return sizeof(struct var_mtrr_context) + mtrr_count * 2 * sizeof(msr_t); return sizeof(struct var_mtrr_context) + mtrr_count * 2 * sizeof(msr_t);
} }
int postcar_frame_init(struct postcar_frame *pcf) static int postcar_frame_init(struct postcar_frame *pcf)
{ {
struct var_mtrr_context *ctx; struct var_mtrr_context *ctx;
@ -57,6 +57,8 @@ static void postcar_frame_common_mtrrs(struct postcar_frame *pcf)
postcar_frame_add_romcache(pcf, MTRR_TYPE_WRPROT); postcar_frame_add_romcache(pcf, MTRR_TYPE_WRPROT);
} }
static void run_postcar_phase(struct postcar_frame *pcf);
/* prepare_and_run_postcar() determines the stack to use after /* prepare_and_run_postcar() determines the stack to use after
* cache-as-ram is torn down as well as the MTRR settings to use. */ * cache-as-ram is torn down as well as the MTRR settings to use. */
void prepare_and_run_postcar(struct postcar_frame *pcf) void prepare_and_run_postcar(struct postcar_frame *pcf)
@ -129,7 +131,7 @@ static void postcar_cache_invalid(void)
board_reset(); board_reset();
} }
void run_postcar_phase(struct postcar_frame *pcf) static void run_postcar_phase(struct postcar_frame *pcf)
{ {
struct prog prog = struct prog prog =
PROG_INIT(PROG_POSTCAR, CONFIG_CBFS_PREFIX "/postcar"); PROG_INIT(PROG_POSTCAR, CONFIG_CBFS_PREFIX "/postcar");