GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/mediatek/mt8173/spi.c: Change assert to if statement 

Asserts are only fatal if CONFIG_FATAL_ASSERTS is enabled in Kconfig.
By default this is disabled, so the assert is generally just a printf.

Die if someone decides to pass in an invalid bus number for some reason.

Addresses coverity issue 1349858 - Out-of-bounds read

Signed-off-by: Martin Roth <martinroth@google.com>
Change-Id: I9d79bc336cbbfde31f655cfd271f101e7a90ab1b
Reviewed-on: https://review.coreboot.org/17484
Reviewed-by: Nico Huber <nico.h@gmx.de>
This commit is contained in:
Martin Roth 2016-11-18 09:54:23 -07:00 committed by Nico Huber
parent c8c5ae101a
commit ba1730b181
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/soc/mediatek/mt8173/spi.c
View File

@ -80,8 +80,11 @@ void mtk_spi_init(unsigned int bus, unsigned int pad_select,
unsigned int speed_hz)
{
u32 div, sck_ticks, cs_ticks, reg_val;
/* mtk spi HW just support bus 0 */
assert(bus == 0);
/* mtk spi HW just supports bus 0 */
if (bus != 0)
die("Error: Only SPI bus 0 is supported.\n");
struct mtk_spi_bus *slave = &spi_bus[bus];
struct mtk_spi_regs *regs = slave->regs;