GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

sb/intel, ACPI: Do not override FADT preferred_pm_profile 

Setting preferred_pm_profile under sb/ overrides the
default determined from SYSTEM_TYPE_xx (or possibly
SMBIOS_ENCLOSURE_TYPE with followup work). This is not desireable.

Boards need to either select a pre-defined SYSTEM_TYPE_xx or provide
board-specific mainboard_fill_fadt() should they need to change this.

As they already select SYSTEM_TYPE_LAPTOP, following boards
will maintain PM_MOBILE:

  lenovo/t400
  lenovo/x200
  roda/rk9

Following will change to PM_DESKTOP:

  aopen/dxplplusu
  asus/p2b
  emulation/qemu-i440fx
  emulation/qemu-q35

Change-Id: I2986eb0a8abc94507e9797cc8b64611ae4bd888a
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/42186
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
This commit is contained in:
Kyösti Mälkki 2020-06-02 15:33:04 +03:00 committed by Felix Held
parent 64e07ebde2
commit ba17829de4
3 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/southbridge/intel/i82371eb/fadt.c
View File

@ -18,7 +18,6 @@
*/ */
void acpi_fill_fadt(acpi_fadt_t *fadt) void acpi_fill_fadt(acpi_fadt_t *fadt)
{ {
fadt->preferred_pm_profile = 0; /* unspecified */
fadt->sci_int = 9; fadt->sci_int = 9;
if (permanent_smi_handler()) { if (permanent_smi_handler()) {

1
src/southbridge/intel/i82801dx/fadt.c
View File

@ -21,7 +21,6 @@ void acpi_fill_fadt(acpi_fadt_t *fadt)
{ {
u16 pmbase = pci_read_config16(pcidev_on_root(0x1f, 0), 0x40) & 0xfffe; u16 pmbase = pci_read_config16(pcidev_on_root(0x1f, 0), 0x40) & 0xfffe;
fadt->preferred_pm_profile = PM_UNSPECIFIED;
fadt->sci_int = 0x9; fadt->sci_int = 0x9;

1
src/southbridge/intel/i82801ix/fadt.c
View File

@ -10,7 +10,6 @@ void acpi_fill_fadt(acpi_fadt_t *fadt)
{ {
u16 pmbase = pci_read_config16(pcidev_on_root(0x1f, 0), 0x40) & 0xfffe; u16 pmbase = pci_read_config16(pcidev_on_root(0x1f, 0), 0x40) & 0xfffe;
fadt->preferred_pm_profile = PM_MOBILE;
fadt->sci_int = 0x9; fadt->sci_int = 0x9;
if (permanent_smi_handler()) { if (permanent_smi_handler()) {