GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

northbridge/amd/amdmct: Superfluous parenthesis in if-statements 

Remove superfluous parenthesis found in some if-statements, spotted by
Clang.

Change-Id: I98d2bf6b408caf320c5bcc8adb23d621b182976b
Signed-off-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
Reviewed-on: http://review.coreboot.org/5817
Tested-by: build bot (Jenkins)
Reviewed-by: Marc Jones <marc.jones@se-eng.com>
This commit is contained in:
Edward O'Callaghan 2014-05-23 05:58:27 +10:00 committed by Marc Jones
parent de6c3c846a
commit ba363d3f18
3 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/northbridge/amd/amdmct/mct/mct_d.c
View File

@ -1532,27 +1532,27 @@ static u8 AutoConfig_D(struct MCTStatStruc *pMCTstat,
DramConfigLo |= 1 << 4; /* 75 Ohms ODT */ DramConfigLo |= 1 << 4; /* 75 Ohms ODT */
if (mctGet_NVbits(NV_MAX_DIMMS) == 8) { if (mctGet_NVbits(NV_MAX_DIMMS) == 8) {
if (pDCTstat->Speed == 3) { if (pDCTstat->Speed == 3) {
if ((pDCTstat->MAdimms[dct] == 4)) if (pDCTstat->MAdimms[dct] == 4)
DramConfigLo |= 1 << 5; /* 50 Ohms ODT */ DramConfigLo |= 1 << 5; /* 50 Ohms ODT */
} else if (pDCTstat->Speed == 4){ } else if (pDCTstat->Speed == 4){
if ((pDCTstat->MAdimms[dct] != 1)) if (pDCTstat->MAdimms[dct] != 1)
DramConfigLo |= 1 << 5; /* 50 Ohms ODT */ DramConfigLo |= 1 << 5; /* 50 Ohms ODT */
} }
} else { } else {
// FIXME: Skip for Ax versions // FIXME: Skip for Ax versions
if ((pDCTstat->MAdimms[dct] == 4)) { if (pDCTstat->MAdimms[dct] == 4) {
if ( pDCTstat->DimmQRPresent != 0) { if ( pDCTstat->DimmQRPresent != 0) {
if ((pDCTstat->Speed == 3) || (pDCTstat->Speed == 4)) { if ((pDCTstat->Speed == 3) || (pDCTstat->Speed == 4)) {
DramConfigLo |= 1 << 5; /* 50 Ohms ODT */ DramConfigLo |= 1 << 5; /* 50 Ohms ODT */
} }
} else if ((pDCTstat->MAdimms[dct] == 4)) { } else if (pDCTstat->MAdimms[dct] == 4) {
if (pDCTstat->Speed == 4) { if (pDCTstat->Speed == 4) {
if ( pDCTstat->DimmQRPresent != 0) { if ( pDCTstat->DimmQRPresent != 0) {
DramConfigLo |= 1 << 5; /* 50 Ohms ODT */ DramConfigLo |= 1 << 5; /* 50 Ohms ODT */
} }
} }
} }
} else if ((pDCTstat->MAdimms[dct] == 2)) { } else if (pDCTstat->MAdimms[dct] == 2) {
DramConfigLo |= 1 << 5; /* 50 Ohms ODT */ DramConfigLo |= 1 << 5; /* 50 Ohms ODT */
} }

2
src/northbridge/amd/amdmct/mct_ddr3/mct_d.c
View File

@ -3380,7 +3380,7 @@ static void mct_BeforeDramInit_Prod_D(struct MCTStatStruc *pMCTstat,
u32 dev = pDCTstat->dev_dct; u32 dev = pDCTstat->dev_dct;
if (pDCTstat->LogicalCPUID & AMD_DR_Dx) { if (pDCTstat->LogicalCPUID & AMD_DR_Dx) {
if ((pDCTstat->Speed == 3)) if (pDCTstat->Speed == 3)
dword = 0x00000800; dword = 0x00000800;
else else
dword = 0x00000000; dword = 0x00000000;

2
src/northbridge/amd/amdmct/mct_ddr3/mhwlc_d.c
View File

@ -502,7 +502,7 @@ void prepareDimms(sMCTStruct *pMCTData, sDCTStruct *pDCTData, u8 dimm, BOOL wl)
} }
} }
else { /* 1 or 4 Dimms per channel */ else { /* 1 or 4 Dimms per channel */
if ((pDCTData->MaxDimmsInstalled == 4)) if (pDCTData->MaxDimmsInstalled == 4)
{ {
tempW1 = 0x04; /* Rtt_Nom=RZQ/4=60 Ohm */ tempW1 = 0x04; /* Rtt_Nom=RZQ/4=60 Ohm */
} }