GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/mediatek: Remove misleading memory logs 

When MRC cache region type is not found (for example, in recovery mode
with !HAS_RECOVERY_MRC_CACHE), mrc_cache_stash_data() will return 0.
Therefore, the platform code is not able to tell from the return value
if the MRC cache data is actually written to flash or not. Since the MRC
driver is already pretty verbose, ignore the return value and remove the
misleading memory logs.

BUG=none
TEST=emerge-asurada coreboot
BRANCH=asurada

Change-Id: I6b411664ca91b9be2d4518a09e9734d26db02d6e
Signed-off-by: Yu-Ping Wu <yupingso@chromium.org>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/52361
Reviewed-by: Hung-Te Lin <hungte@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Yu-Ping Wu 2021-04-15 10:06:27 +08:00 committed by Patrick Georgi
parent 46ca25d8c9
commit ba49444c33
1 changed files with 7 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/soc/mediatek/common/memory.c
View File

@ -195,11 +195,10 @@ static void mt_mem_init_run(struct dramc_param *dparam,
/* Erase flash data after fast calibration failed */ /* Erase flash data after fast calibration failed */
memset(&dparam->dramc_datas, 0xa5, mrc_cache_size); memset(&dparam->dramc_datas, 0xa5, mrc_cache_size);
if (mrc_cache_stash_data(MRC_TRAINING_DATA, mrc_cache_stash_data(MRC_TRAINING_DATA,
DRAMC_PARAM_HEADER_VERSION, DRAMC_PARAM_HEADER_VERSION,
&dparam->dramc_datas, mrc_cache_size)) &dparam->dramc_datas,
printk(BIOS_ERR, "DRAM-K: Failed to erase " mrc_cache_size);
"calibration data\n");
} else { } else {
printk(BIOS_INFO, "DRAM-K: Fast calibration passed in %ld msecs\n", printk(BIOS_INFO, "DRAM-K: Fast calibration passed in %ld msecs\n",
stopwatch_duration_msecs(&sw)); stopwatch_duration_msecs(&sw));
@ -219,16 +218,9 @@ static void mt_mem_init_run(struct dramc_param *dparam,
if (err == 0) { if (err == 0) {
printk(BIOS_INFO, "DRAM-K: Full calibration passed in %ld msecs\n", printk(BIOS_INFO, "DRAM-K: Full calibration passed in %ld msecs\n",
stopwatch_duration_msecs(&sw)); stopwatch_duration_msecs(&sw));
mrc_cache_stash_data(MRC_TRAINING_DATA,
if (mrc_cache_stash_data(MRC_TRAINING_DATA, DRAMC_PARAM_HEADER_VERSION,
DRAMC_PARAM_HEADER_VERSION, &dparam->dramc_datas, mrc_cache_size);
&dparam->dramc_datas, mrc_cache_size) == 0)
printk(BIOS_DEBUG, "DRAM-K: Calibration params saved "
"to flash: version=%#x, size=%#zx\n",
DRAMC_PARAM_HEADER_VERSION, sizeof(*dparam));
else
printk(BIOS_ERR, "DRAM-K: Failed to save calibration "
"data to flash\n");
} else { } else {
printk(BIOS_ERR, "DRAM-K: Full calibration failed in %ld msecs\n", printk(BIOS_ERR, "DRAM-K: Full calibration failed in %ld msecs\n",
stopwatch_duration_msecs(&sw)); stopwatch_duration_msecs(&sw));