GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

southbridge/amd/pi/hudson: Fix HUDSON_DISABLE_IMC kconfig warning 

Platforms selecting the HUDSON_DISABLE_IMC symbol were showing the
warning:

warning: (BOARD_SPECIFIC_OPTIONS && BOARD_SPECIFIC_OPTIONS &&
CPU_AMD_AGESA_BINARY_PI) selects HUDSON_DISABLE_IMC which has unmet
direct dependencies (SOUTHBRIDGE_AMD_PI_AVALON ||
SOUTHBRIDGE_AMD_PI_BOLTON || SOUTHBRIDGE_AMD_PI_KERN)

By moving the definition of the symbol outside of the if block
and removing the default n, we can get rid of the warning without
changing the value for any platform.

Change-Id: I5c1bdfbcf3c5c44ee05b8c5e679f6854d784d8dc
Signed-off-by: Martin Roth <gaumless@gmail.com>
Reviewed-on: http://review.coreboot.org/10680
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Idwer Vollering <vidwer@gmail.com>
This commit is contained in:
Martin Roth 2015-06-28 09:44:31 -06:00
parent 3a391fd20c
commit ba566bdc8b
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/southbridge/amd/pi/hudson/Kconfig
View File

@ -35,6 +35,9 @@ config SOUTHBRIDGE_AMD_PI_KERN
select HAVE_USBDEBUG_OPTIONS select HAVE_USBDEBUG_OPTIONS
select HAVE_HARD_RESET select HAVE_HARD_RESET
config HUDSON_DISABLE_IMC
bool
if SOUTHBRIDGE_AMD_PI_AVALON || SOUTHBRIDGE_AMD_PI_BOLTON || SOUTHBRIDGE_AMD_PI_KERN if SOUTHBRIDGE_AMD_PI_AVALON || SOUTHBRIDGE_AMD_PI_BOLTON || SOUTHBRIDGE_AMD_PI_KERN
config BOOTBLOCK_SOUTHBRIDGE_INIT config BOOTBLOCK_SOUTHBRIDGE_INIT
@ -65,10 +68,6 @@ config HUDSON_XHCI_FWM
help help
Add Hudson 2/3/4 XHCI Firmware to support the onboard USB 3.0 Add Hudson 2/3/4 XHCI Firmware to support the onboard USB 3.0
config HUDSON_DISABLE_IMC
bool
default n
config HUDSON_IMC_FWM config HUDSON_IMC_FWM
bool "Add IMC firmware" bool "Add IMC firmware"
depends on !HUDSON_DISABLE_IMC depends on !HUDSON_DISABLE_IMC