GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

rambi: make ramids non-legacy gpio inputs 

The romstage code for rambi uses the mmio way of reading
inputs. However, this is a problem is the GPIOs are set up
as legacy mode. Subsequent warm resets mean the ram_id is
read incorrectly. Ensure the ram_id is read consistently
by keeping the GPIOs for ram_id in mmio mode.

BUG=chrome-os-partner:24085
BRANCH=None
TEST=Built and booted. And rebooted. Now seeing consistent ram_id
     values on warm resets.

Change-Id: Ieff98c000be80998854f325754f1e819975d2be5
Signed-off-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/177230
Reviewed-by: Shawn Nematbakhsh <shawnn@chromium.org>
Reviewed-on: http://review.coreboot.org/4977
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <patrick@georgi-clan.de>
This commit is contained in:
Aaron Durbin 2013-11-18 13:50:02 -06:00 committed by Kyösti Mälkki
parent 6f9947a3ec
commit baa1e38217
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/mainboard/google/rambi/gpio.c
View File

@ -200,9 +200,9 @@ static const struct soc_gpio_map gpssus_gpio_map[] = {
GPIO_NC, /* S534 - NC */ GPIO_NC, /* S534 - NC */
GPIO_OUT_HIGH, /* S535 - LTE_DISABLE_L */ GPIO_OUT_HIGH, /* S535 - LTE_DISABLE_L */
GPIO_NC, /* S536 - NC */ GPIO_NC, /* S536 - NC */
GPIO_INPUT, /* S537 - RAM_ID0 */ GPIO_FUNC0, /* S537 - RAM_ID0 */
GPIO_INPUT, /* S538 - RAM_ID1 */ GPIO_FUNC0, /* S538 - RAM_ID1 */
GPIO_INPUT, /* S539 - RAM_ID2 */ GPIO_FUNC0, /* S539 - RAM_ID2 */
GPIO_NC, /* S540 - NC */ GPIO_NC, /* S540 - NC */
GPIO_NC, /* S541 - NC */ GPIO_NC, /* S541 - NC */
GPIO_NC, /* S542 - NC */ GPIO_NC, /* S542 - NC */