GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/cmn/spi: Separate fast SPI device from generic SPI driver 

The fast SPI controller (usually handling the boot NOR flash) is a
different controller type than the generic SPI controllers as it
provides access to the boot flash and usually is not used for generic
SPI slave connections.

Though there is common code for the fast SPI controller it currently do
not uses the PCI driver structure. This patch adds the PCI driver
envelope to the fast SPI driver and moves Apollo Lake as the first
platform to this driver.

Change-Id: I31bf39ec1c622db887dec9ca8623a7f282402849
Signed-off-by: Werner Zeh <werner.zeh@siemens.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/64075
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Subrata Banik <subratabanik@google.com>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
Werner Zeh 2022-05-05 11:04:04 +02:00 committed by Felix Held
parent 8da3804430
commit bae8498486
2 changed files with 19 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/soc/intel/common/block/fast_spi/fast_spi.c
View File

@ -5,7 +5,9 @@
#include <arch/romstage.h> #include <arch/romstage.h>
#include <device/mmio.h> #include <device/mmio.h>
#include <assert.h> #include <assert.h>
#include <device/pci.h>
#include <device/pci_def.h> #include <device/pci_def.h>
#include <device/pci_ids.h>
#include <device/pci_ops.h> #include <device/pci_ops.h>
#include <console/console.h> #include <console/console.h>
#include <commonlib/helpers.h> #include <commonlib/helpers.h>
@ -453,3 +455,20 @@ void fast_spi_clear_outstanding_status(void)
/* Make sure all W1C status bits get cleared. */ /* Make sure all W1C status bits get cleared. */
write32(spibar + SPIBAR_HSFSTS_CTL, SPIBAR_HSFSTS_W1C_BITS); write32(spibar + SPIBAR_HSFSTS_CTL, SPIBAR_HSFSTS_W1C_BITS);
} }
static struct device_operations fast_spi_dev_ops = {
.read_resources = pci_dev_read_resources,
.set_resources = pci_dev_set_resources,
.enable_resources = pci_dev_enable_resources,
};
static const unsigned short pci_device_ids[] = {
PCI_DID_INTEL_APL_HWSEQ_SPI,
0
};
static const struct pci_driver fast_spi __pci_driver = {
.ops = &fast_spi_dev_ops,
.vendor = PCI_VID_INTEL,
.devices = pci_device_ids,
};

1
src/soc/intel/common/block/spi/spi.c
View File

@ -130,7 +130,6 @@ static const unsigned short pci_device_ids[] = {
PCI_DID_INTEL_APL_SPI0, PCI_DID_INTEL_APL_SPI0,
PCI_DID_INTEL_APL_SPI1, PCI_DID_INTEL_APL_SPI1,
PCI_DID_INTEL_APL_SPI2, PCI_DID_INTEL_APL_SPI2,
PCI_DID_INTEL_APL_HWSEQ_SPI,
PCI_DID_INTEL_GLK_SPI0, PCI_DID_INTEL_GLK_SPI0,
PCI_DID_INTEL_GLK_SPI1, PCI_DID_INTEL_GLK_SPI1,
PCI_DID_INTEL_GLK_SPI2, PCI_DID_INTEL_GLK_SPI2,