From baf00e6b28efcf02497a566fa6f0f43d11304406 Mon Sep 17 00:00:00 2001 From: Martin Roth Date: Wed, 13 Jan 2016 11:54:18 -0700 Subject: [PATCH] intel/skylake/pcr.c: error out on invalid size in pcr read/write The read and write routines take a number of bytes to write, which should be 1,2, or 4. We now return an error if an invalid size is specified. Change-Id: I93344bc0837c3715fc7660503f405c8878eb711c Signed-off-by: Martin Roth Reviewed-on: https://review.coreboot.org/12936 Tested-by: build bot (Jenkins) Reviewed-by: Nico Huber --- src/soc/intel/skylake/pcr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/soc/intel/skylake/pcr.c b/src/soc/intel/skylake/pcr.c index 7efbb2547a..b6de73c74c 100644 --- a/src/soc/intel/skylake/pcr.c +++ b/src/soc/intel/skylake/pcr.c @@ -63,7 +63,7 @@ static int pch_pcr_read(u8 pid, u16 offset, u32 size, void *data) *(u8 *) data = read8(pcr_reg_address(pid, offset)); break; default: - break; + return -1; } return 0; } @@ -123,7 +123,7 @@ static int pch_pcr_write(u8 pid, u16 offset, u32 size, u32 data) write8(pcr_reg_address(pid, offset), (u8) data); break; default: - break; + return -1; } /* Ensure the writes complete. */ complete_write();