GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/hatch/kohaku: Fix touchscreen power sequencing 

Commit 525c61f74e ("mb/google/hatch: Implement touchscreen power
sequencing") contained a copy/paste error; KOHAKU's enable GPIO is set
twice in ramstage, and the reset GPIO not at all, leading the
touchscreen to not be detected.

Correct the copy/paste error by replacing the 2nd instance of GPP_C12
with GPP_D15.

TEST=build/boot Windows/Linux on KOHAKU, verify touchscreen works.

Change-Id: I08d35f1e2a951cdaa463daa34df2134fdc8c65c8
Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/72119
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
Matt DeVillier 2023-01-19 15:25:39 -06:00 committed by Felix Held
parent 2e82fcf209
commit bb18968968
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/mainboard/google/hatch/variants/kohaku/gpio.c
View File

@ -37,7 +37,7 @@ static const struct pad_config gpio_table[] = {
/* C23 : UART2_CTS# ==> NC */ /* C23 : UART2_CTS# ==> NC */
PAD_NC(GPP_C23, NONE), PAD_NC(GPP_C23, NONE),
/* D15 : TOUCHSCREEN_RST_L */ /* D15 : TOUCHSCREEN_RST_L */
PAD_CFG_GPO(GPP_C12, 1, DEEP), PAD_CFG_GPO(GPP_D15, 1, DEEP),
/* D16 : TOUCHSCREEN_INT_L */ /* D16 : TOUCHSCREEN_INT_L */
PAD_CFG_GPI_APIC(GPP_D16, NONE, PLTRST, LEVEL, INVERT), PAD_CFG_GPI_APIC(GPP_D16, NONE, PLTRST, LEVEL, INVERT),
/* E23 : GPP_E23 ==> NC */ /* E23 : GPP_E23 ==> NC */