GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/poppy/variants/nautilus: Add gpio-keys ACPI node for PENH 

This change uses gpio_keys driver to add ACPI node for pen eject event.

BUG=b:71329519
TEST=Verified using evtest that pen eject event results in events as
expected.

Change-Id: Ib293c2ca532c8ed9e2587143b1a69300cd9fa4e9
Signed-off-by: Furquan Shaikh <furquan@chromium.org>
Reviewed-on: https://review.coreboot.org/23238
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Duncan Laurie <dlaurie@chromium.org>
This commit is contained in:
Furquan Shaikh 2018-01-11 20:29:38 -08:00 committed by Furquan Shaikh
parent 3c8e00e4cc
commit bb1e539f14
3 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/mainboard/google/poppy/Kconfig
View File

@ -2,6 +2,7 @@
config BOARD_GOOGLE_BASEBOARD_POPPY config BOARD_GOOGLE_BASEBOARD_POPPY
def_bool n def_bool n
select BOARD_ROMSIZE_KB_16384 select BOARD_ROMSIZE_KB_16384
select DRIVERS_GENERIC_GPIO_KEYS
select DRIVERS_I2C_GENERIC select DRIVERS_I2C_GENERIC
select DRIVERS_I2C_HID select DRIVERS_I2C_HID
select EC_GOOGLE_CHROMEEC select EC_GOOGLE_CHROMEEC

9
src/mainboard/google/poppy/variants/nautilus/devicetree.cb
View File

@ -321,6 +321,15 @@ chip soc/intel/skylake
register "hid_desc_reg_offset" = "0x1" register "hid_desc_reg_offset" = "0x1"
device i2c 0x9 on end device i2c 0x9 on end
end end
chip drivers/generic/gpio_keys
register "name" = ""PENH""
register "gpio" = "ACPI_GPIO_INPUT_ACTIVE_LOW(GPP_B19)"
register "key.dev_name" = ""EJCT""
register "key.linux_code" = "SW_PEN_INSERTED"
register "key.linux_input_type" = "EV_SW"
register "key.label" = ""pen_eject""
device generic 0 on end
end
end # I2C #3 end # I2C #3
device pci 16.0 on end # Management Engine Interface 1 device pci 16.0 on end # Management Engine Interface 1
device pci 16.1 off end # Management Engine Interface 2 device pci 16.1 off end # Management Engine Interface 2

2
src/mainboard/google/poppy/variants/nautilus/gpio.c
View File

@ -101,7 +101,7 @@ static const struct pad_config gpio_table[] = {
/* B18 : GSPI0_MOSI ==> NC */ /* B18 : GSPI0_MOSI ==> NC */
PAD_CFG_NC(GPP_B18), PAD_CFG_NC(GPP_B18),
/* B19 : GSPI1_CS# ==> CHP3_PEN_EJECT - for notification */ /* B19 : GSPI1_CS# ==> CHP3_PEN_EJECT - for notification */
PAD_CFG_GPI(GPP_B19, NONE, DEEP), PAD_CFG_GPI_GPIO_DRIVER(GPP_B19, NONE, DEEP),
/* B20 : GSPI1_CLK ==> NC */ /* B20 : GSPI1_CLK ==> NC */
PAD_CFG_NC(GPP_B20), PAD_CFG_NC(GPP_B20),
/* B21 : GSPI1_MISO ==> CHP3_PEN_EJECT - for wake event */ /* B21 : GSPI1_MISO ==> CHP3_PEN_EJECT - for wake event */