From bb7424f30c3b7b8938326f75123b39c0ba4c4027 Mon Sep 17 00:00:00 2001 From: Richard Spiegel Date: Wed, 8 Aug 2018 09:58:34 -0700 Subject: [PATCH] arch/x86/tables.c: Avoid static analysis error for unused value Within procedure arch_write_tables, the pointer "rom_table_end" is updated every time a table is created. However, after creating last table, pointer rom_table_end is not used, though it is updated. Add a "(void)rom_table_end;" at the end to avoid the static analysis error. BUG=b:112253891 TEST=Build and boot grunt. Change-Id: I8a34026795c7f0d1bb86c5f5c0469d40aa53994a Signed-off-by: Richard Spiegel Reviewed-on: https://review.coreboot.org/27958 Tested-by: build bot (Jenkins) Reviewed-by: Martin Roth --- src/arch/x86/tables.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/arch/x86/tables.c b/src/arch/x86/tables.c index 0a9a3d59b4..0bab4234c9 100644 --- a/src/arch/x86/tables.c +++ b/src/arch/x86/tables.c @@ -259,6 +259,9 @@ void arch_write_tables(uintptr_t coreboot_table) forwarding_table += sz; /* Align up to page boundary for historical consistency. */ forwarding_table = ALIGN_UP(forwarding_table, 4*KiB); + + /* Tell static analysis we know value is left unused. */ + (void)rom_table_end; } void bootmem_arch_add_ranges(void)