GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd/stoneyridge: Remove printk for GPIO 

The printk() calls in sb_program_gpios() aren't necessary, and incur a
13 second delay if the function is called from
bootblock_mainboard_early_init(). This commit removes them so GPIOs can
be set up earlier.

TEST=call sb_program_gpios from bootblock_mainboard_early_init
BUG=b:73898539

Change-Id: I064291decf47d86132e36469e029b3262ec20172
Signed-off-by: Justin TerAvest <teravest@chromium.org>
Reviewed-on: https://review.coreboot.org/24915
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Justin TerAvest 2018-02-28 11:42:38 -07:00 committed by Martin Roth
parent a8c9efe655
commit bb75effd87
2 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/soc/amd/stoneyridge/include/soc/southbridge.h
View File

@ -288,7 +288,6 @@
#else
#define GPIO_TABLE_BOOTBLOCK 0
#endif
#define STR_GPIO_STAGE ENV_STRING
struct soc_amd_stoneyridge_gpio {
uint8_t gpio;

2
src/soc/amd/stoneyridge/southbridge.c
View File

@ -161,7 +161,6 @@ void sb_program_gpios(const struct soc_amd_stoneyridge_gpio *gpio_ptr,
void *tmp_ptr;
uint8_t control, mux, index;
printk(BIOS_SPEW, "GPIO programming stage %s\n", STR_GPIO_STAGE);
for (index = 0; index < size; index++) {
mux = gpio_ptr[index].function;
control = gpio_ptr[index].control;
@ -176,7 +175,6 @@ void sb_program_gpios(const struct soc_amd_stoneyridge_gpio *gpio_ptr,
AMD_GPIO_CONTROL + 2);
write8(tmp_ptr, control);
}
printk(BIOS_SPEW, "End GPIO programming\n");
}
/**