GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd/common: Remove unused variables of write_pci_cfg_irqs() 

Function write_pci_cfg_irqs() has "no function" variables. One variable is
set and never used, the other is only used to control a print. Remove them.

BUG=b:117950052
TEST=Build grunt.

Change-Id: Icd98db3e794e609b112f15979a3a00a2977a0fdb
Signed-off-by: Richard Spiegel <richard.spiegel@silverbackltd.com>
Reviewed-on: https://review.coreboot.org/29244
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>
This commit is contained in:
Richard Spiegel 2018-10-23 08:59:18 -07:00 committed by Patrick Georgi
parent 9eb4d0a069
commit bc0c364ea3
1 changed files with 0 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/soc/amd/common/block/pci/amd_pci_util.c
View File

@ -104,9 +104,7 @@ void write_pci_cfg_irqs(void)
u16 target_pin = 0; u16 target_pin = 0;
u16 int_line = 0; u16 int_line = 0;
u16 pci_intr_idx = 0; /* Index into PCI_INTR table, 0xC00/0xC01 */ u16 pci_intr_idx = 0; /* Index into PCI_INTR table, 0xC00/0xC01 */
u8 bus = 0; /* TODO: no longer used, remove it */
u16 devfn = 0; u16 devfn = 0;
u8 bridged_device = 0; /* TODO: Remove this */
u32 i = 0; u32 i = 0;
size_t limit; size_t limit;
const struct irq_idx_name *idx_name; const struct irq_idx_name *idx_name;
@ -141,7 +139,6 @@ void write_pci_cfg_irqs(void)
if (int_pin < 1 || int_pin > 4) if (int_pin < 1 || int_pin > 4)
continue; /* Device has invalid INT_PIN - skip */ continue; /* Device has invalid INT_PIN - skip */
bus = target_dev->bus->secondary;
devfn = target_dev->path.pci.devfn; devfn = target_dev->path.pci.devfn;
/* /*
@ -217,10 +214,6 @@ void write_pci_cfg_irqs(void)
*/ */
printk(BIOS_SPEW, "\tOrig INT_PIN\t: %d (%s)\n", printk(BIOS_SPEW, "\tOrig INT_PIN\t: %d (%s)\n",
int_pin, pin_to_str(int_pin)); int_pin, pin_to_str(int_pin));
if (bridged_device)
printk(BIOS_SPEW, "\tSwizzled to\t: %d (%s)\n",
target_pin, pin_to_str(target_pin));
printk(BIOS_SPEW, "\tPCI_INTR idx\t: 0x%02x (%s)\n" printk(BIOS_SPEW, "\tPCI_INTR idx\t: 0x%02x (%s)\n"
"\tINT_LINE\t: 0x%X (IRQ %d)\n", "\tINT_LINE\t: 0x%X (IRQ %d)\n",
pci_intr_idx, idx_name[i].name, pci_intr_idx, idx_name[i].name,