GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

amd/thatcher: Removed #include early_serial.c from romstage 

Remove dependency on early_serial.c and instead use the
Super I/O's header to access the functions needed.

Change-Id: I9edf7fc2501aa832106dda9213e702dbcc1200b4
Signed-off-by: Antonello Dettori <dev@dettori.io>
Reviewed-on: https://review.coreboot.org/13887
Reviewed-by: Martin Roth <martinroth@google.com>
Tested-by: build bot (Jenkins)
This commit is contained in:
Antonello Dettori 2016-03-03 16:25:35 +00:00 committed by Patrick Georgi
parent 98b5f907ac
commit bc839fba3d
4 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/mainboard/amd/thatcher/romstage.c
View File

@ -30,7 +30,7 @@
#include <cpu/x86/bist.h> #include <cpu/x86/bist.h>
#include <cpu/x86/lapic.h> #include <cpu/x86/lapic.h>
#include <southbridge/amd/agesa/hudson/hudson.h> #include <southbridge/amd/agesa/hudson/hudson.h>
#include <superio/smsc/lpc47n217/early_serial.c> #include <superio/smsc/lpc47n217/lpc47n217.h>
#include <cpu/amd/agesa/s3_resume.h> #include <cpu/amd/agesa/s3_resume.h>
#include "cbmem.h" #include "cbmem.h"

1
src/superio/smsc/lpc47n217/Makefile.inc
View File

@ -14,4 +14,5 @@
## GNU General Public License for more details. ## GNU General Public License for more details.
## ##
romstage-$(CONFIG_SUPERIO_SMSC_LPC47N217) += early_serial.c
ramstage-$(CONFIG_SUPERIO_SMSC_LPC47N217) += superio.c ramstage-$(CONFIG_SUPERIO_SMSC_LPC47N217) += superio.c

2
src/superio/smsc/lpc47n217/early_serial.c
View File

@ -105,7 +105,7 @@ static void lpc47n217_pnp_set_enable(pnp_devfn_t dev, int enable)
* @param dev High 8 bits = Super I/O port, low 8 bits = logical device number. * @param dev High 8 bits = Super I/O port, low 8 bits = logical device number.
* @param iobase Processor I/O port address to assign to this serial device. * @param iobase Processor I/O port address to assign to this serial device.
*/ */
static void lpc47n217_enable_serial(pnp_devfn_t dev, u16 iobase) void lpc47n217_enable_serial(pnp_devfn_t dev, u16 iobase)
{ {
/* /*
* NOTE: Cannot use pnp_set_XXX() here because they assume chip * NOTE: Cannot use pnp_set_XXX() here because they assume chip

5
src/superio/smsc/lpc47n217/lpc47n217.h
View File

@ -17,6 +17,9 @@
#ifndef SUPERIO_SMSC_LPC47N217_LPC47N217_H #ifndef SUPERIO_SMSC_LPC47N217_LPC47N217_H
#define SUPERIO_SMSC_LPC47N217_LPC47N217_H #define SUPERIO_SMSC_LPC47N217_LPC47N217_H
#include <arch/io.h>
#include <stdint.h>
/* /*
* These are arbitrary, but must match declarations in the mainboard * These are arbitrary, but must match declarations in the mainboard
* devicetree.cb file. Values chosen to match SMSC LPC47B37x. * devicetree.cb file. Values chosen to match SMSC LPC47B37x.
@ -27,4 +30,6 @@
#define LPC47N217_MAX_CONFIG_REGISTER 0x39 #define LPC47N217_MAX_CONFIG_REGISTER 0x39
void lpc47n217_enable_serial(pnp_devfn_t dev, u16 iobase);
#endif #endif