GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/nvidia/tegra124: add resources during read_resources() 

The chipset code was incorrectly adding memory resources
to the domain device after resource allocation occurred.
It's not possible to get the correct view of the address space,
and it's generally incorrect to not add resources during
read_resources(). This change fixes the order by adding resources in
read_resources().

Signed-off-by: Furquan Shaikh <furquan@google.com>
Change-Id: I16f0439679471366723a0084918a20cd95834831
Reviewed-on: https://review.coreboot.org/c/coreboot/+/41372
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Furquan Shaikh 2020-05-13 12:19:15 -07:00 committed by Aaron Durbin
parent 1dac605872
commit bcac1cbacd
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/soc/nvidia/tegra124/soc.c
View File

@ -14,7 +14,7 @@
* Will break if we get 2. Sigh. * Will break if we get 2. Sigh.
* We assume it's all multiples of MiB for MMUs sake. * We assume it's all multiples of MiB for MMUs sake.
*/ */
static void soc_enable(struct device *dev) static void soc_read_resources(struct device *dev)
{ {
u32 lcdbase = fb_base_mb(); u32 lcdbase = fb_base_mb();
unsigned long fb_size = FB_SIZE_MB; unsigned long fb_size = FB_SIZE_MB;
@ -41,9 +41,8 @@ static void soc_init(struct device *dev)
} }
static struct device_operations soc_ops = { static struct device_operations soc_ops = {
.read_resources = noop_read_resources, .read_resources = soc_read_resources,
.set_resources = noop_set_resources, .set_resources = noop_set_resources,
.enable_resources = soc_enable,
.init = soc_init, .init = soc_init,
}; };