GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

board_status.sh minor fixes - no functional changes 

- Update some comments
- Whitespace fixes
- change from backticks to $() format for getting command data.

Change-Id: Iaf424224abfd30a3581d0e43a1689cc7c887beec
Signed-off-by: Martin Roth <martin.roth@se-eng.com>
Reviewed-on: http://review.coreboot.org/6261
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
Reviewed-by: David Hendricks <dhendrix@chromium.org>
This commit is contained in:
Martin Roth 2014-07-10 15:02:19 -06:00 committed by Martin Roth
parent 8e0071b798
commit bcd09930d8
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
util/board_status/board_status.sh
View File

@ -24,7 +24,8 @@ NONFATAL=1
# test a command # test a command
# #
# $1: test command on remote host (0=no, 1=yes) # $1: 0 ($LOCAL) to run command locally,
# 1 ($REMOTE) to run remotely if remote host defined
# $2: command to test # $2: command to test
# $3: 0 ($FATAL) Exit with an error if the command fails # $3: 0 ($FATAL) Exit with an error if the command fails
# 1 ($NONFATAL) Don't exit on command test failure # 1 ($NONFATAL) Don't exit on command test failure
@ -37,7 +38,7 @@ test_cmd()
fi fi
if [ "$1" -eq "$REMOTE" ] && [ -n "$REMOTE_HOST" ]; then if [ "$1" -eq "$REMOTE" ] && [ -n "$REMOTE_HOST" ]; then
ssh root@${REMOTE_HOST} which "$2" >/dev/null ssh root@${REMOTE_HOST} which "$2" > /dev/null
rc=$? rc=$?
else else
which "$2" >/dev/null which "$2" >/dev/null
@ -79,7 +80,8 @@ _cmd()
# run a command # run a command
# #
# $1: 0 to run command locally, 1 to run remotely if remote host defined # $1: 0 ($LOCAL) to run command locally,
# 1 ($REMOTE) to run remotely if remote host defined
# $2: command # $2: command
# $3: filename to direct output of command into # $3: filename to direct output of command into
cmd() cmd()
@ -97,7 +99,8 @@ cmd()
# run a command where failure is considered to be non-fatal # run a command where failure is considered to be non-fatal
# #
# $1: 0 to run command locally, 1 to run remotely if remote host defined # $1: 0 ($LOCAL) to run command locally,
# 1 ($REMOTE) to run remotely if remote host defined
# $2: command # $2: command
# $3: filename to direct output of command into # $3: filename to direct output of command into
cmd_nonfatal() cmd_nonfatal()
@ -253,7 +256,7 @@ cmd $REMOTE dmesg "${tmpdir}/${results}/kernel_log.txt"
# #
# Finish up. # Finish up.
# #
coreboot_dir=`pwd` coreboot_dir=$(pwd)
if [ $UPLOAD_RESULTS -eq 1 ]; then if [ $UPLOAD_RESULTS -eq 1 ]; then
# extract username from ssh://<username>@review.coreboot.org/blah # extract username from ssh://<username>@review.coreboot.org/blah
username=$(git config --get remote.origin.url | sed 's/ssh\:\/\///' | sed 's/@.*//') username=$(git config --get remote.origin.url | sed 's/ssh\:\/\///' | sed 's/@.*//')