From bcf42fb7b1dcef7c616d3598fd947384dc78b916 Mon Sep 17 00:00:00 2001 From: Rex-BC Chen Date: Tue, 15 Jun 2021 20:19:01 +0800 Subject: [PATCH] mb/google/cherry: fix GPIO polarity for TPM interrupt The GPIO_GSC_AP_INT itself is active low, but the payloads will create the IRQ using its eint driver, which is active high. BUG=b:188392736 Signed-off-by: Rex-BC Chen Change-Id: Ie39f3b9a5dbe15057ef3e96f6c99211949692003 Reviewed-on: https://review.coreboot.org/c/coreboot/+/55562 Tested-by: build bot (Jenkins) Reviewed-by: Yu-Ping Wu --- src/mainboard/google/cherry/chromeos.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/mainboard/google/cherry/chromeos.c b/src/mainboard/google/cherry/chromeos.c index 8d4335492c..8f0e9aedf4 100644 --- a/src/mainboard/google/cherry/chromeos.c +++ b/src/mainboard/google/cherry/chromeos.c @@ -26,7 +26,11 @@ void fill_lb_gpios(struct lb_gpios *gpios) {GPIO_SD_CD.id, ACTIVE_LOW, -1, "SD card detect"}, {GPIO_BEEP_ON.id, ACTIVE_HIGH, -1, "beep enable"}, {GPIO_EC_IN_RW.id, ACTIVE_LOW, -1, "EC in RW"}, - {GPIO_GSC_AP_INT.id, ACTIVE_LOW, -1, "TPM interrupt"}, + /* + * The GPIO_GSC_AP_INT itself is active low, but the payloads will + * create the IRQ using its eint driver, which is active high. + */ + {GPIO_GSC_AP_INT.id, ACTIVE_HIGH, -1, "TPM interrupt"}, {GPIO_EN_SPK.id, ACTIVE_HIGH, -1, "speaker enable"}, }; lb_add_gpios(gpios, chromeos_gpios, ARRAY_SIZE(chromeos_gpios));