GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fsp_baytrail: Refactor code for SPI debug messages 

Use the config switch CONFIG_DEBUG_SPI_FLASH on compiler level rather
then on preprocessor level to ensure that the code is compiled even if
the switch is not selected. In addition the following two changes are
introduced:

1. Prepend the debug messages with 'SPI:' to make the output more
   meaningful.
2. Change the address mask from 0xffff to 0x3ff and remove the subtraction
   of the constant value 0xf020 in order to print only the register
   offset within the SPI controller and avoid the visibility of any
   fragments from SPI base address.
3. Switch to uint8_t and friends instead of u8 to sync up with other
   code in the same file.

Change-Id: Iaf46f29a775039007a402fe862839df06a4cbfaa
Signed-off-by: Werner Zeh <werner.zeh@siemens.com>
Reviewed-on: https://review.coreboot.org/16499
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
This commit is contained in:
Werner Zeh 2016-09-05 07:40:29 +02:00 committed by Martin Roth
parent 994d8b4f13
commit bd366ab485
1 changed files with 37 additions and 35 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

72
src/soc/intel/fsp_baytrail/spi.c
View File

@ -1,6 +1,7 @@
/* /*
* Copyright (c) 2011 The Chromium OS Authors. * Copyright (c) 2011 The Chromium OS Authors.
* Copyright (C) 2013-2014 Sage Electronic Engineering, LLC. * Copyright (C) 2013-2014 Sage Electronic Engineering, LLC.
* Copyright (C) 2016 Siemens AG
* *
* This program is free software; you can redistribute it and/or * This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License as * modify it under the terms of the GNU General Public License as
@ -158,64 +159,65 @@ enum {
SPI_OPCODE_TYPE_WRITE_WITH_ADDRESS = 3 SPI_OPCODE_TYPE_WRITE_WITH_ADDRESS = 3
}; };
#if IS_ENABLED(CONFIG_DEBUG_SPI_FLASH) #define SPI_OFFSET_MASK 0x3ff
static u8 readb_(const void *addr) static uint8_t readb_(const void *addr)
{ {
u8 v = read8(addr); uint8_t v = read8(addr);
printk(BIOS_DEBUG, "read %2.2x from %4.4x\n", if (IS_ENABLED(CONFIG_DEBUG_SPI_FLASH)) {
v, ((unsigned) addr & 0xffff) - 0xf020); printk(BIOS_DEBUG, "SPI: read %2.2x from %4.4x\n",
v, (((uint32_t) addr) & SPI_OFFSET_MASK));
}
return v; return v;
} }
static u16 readw_(const void *addr) static uint16_t readw_(const void *addr)
{ {
u16 v = read16(addr); uint16_t v = read16(addr);
printk(BIOS_DEBUG, "read %4.4x from %4.4x\n", if (IS_ENABLED(CONFIG_DEBUG_SPI_FLASH)) {
v, ((unsigned) addr & 0xffff) - 0xf020); printk(BIOS_DEBUG, "SPI: read %4.4x from %4.4x\n",
v, (((uint32_t) addr) & SPI_OFFSET_MASK));
}
return v; return v;
} }
static u32 readl_(const void *addr) static uint32_t readl_(const void *addr)
{ {
u32 v = read32(addr); uint32_t v = read32(addr);
printk(BIOS_DEBUG, "read %8.8x from %4.4x\n", if (IS_ENABLED(CONFIG_DEBUG_SPI_FLASH)) {
v, ((unsigned) addr & 0xffff) - 0xf020); printk(BIOS_DEBUG, "SPI: read %8.8x from %4.4x\n",
v, (((uint32_t) addr) & SPI_OFFSET_MASK));
}
return v; return v;
} }
static void writeb_(u8 b, void *addr) static void writeb_(uint8_t b, void *addr)
{ {
write8(addr, b); write8(addr, b);
printk(BIOS_DEBUG, "wrote %2.2x to %4.4x\n", if (IS_ENABLED(CONFIG_DEBUG_SPI_FLASH)) {
b, ((unsigned) addr & 0xffff) - 0xf020); printk(BIOS_DEBUG, "SPI: wrote %2.2x to %4.4x\n",
b, (((uint32_t) addr) & SPI_OFFSET_MASK));
}
} }
static void writew_(u16 b, void *addr) static void writew_(uint16_t b, void *addr)
{ {
write16(addr, b); write16(addr, b);
printk(BIOS_DEBUG, "wrote %4.4x to %4.4x\n", if (IS_ENABLED(CONFIG_DEBUG_SPI_FLASH)) {
b, ((unsigned) addr & 0xffff) - 0xf020); printk(BIOS_DEBUG, "SPI: wrote %4.4x to %4.4x\n",
b, (((uint32_t) addr) & SPI_OFFSET_MASK));
}
} }
static void writel_(u32 b, void *addr) static void writel_(uint32_t b, void *addr)
{ {
write32(addr, b); write32(addr, b);
printk(BIOS_DEBUG, "wrote %8.8x to %4.4x\n", if (IS_ENABLED(CONFIG_DEBUG_SPI_FLASH)) {
b, ((unsigned) addr & 0xffff) - 0xf020); printk(BIOS_DEBUG, "SPI: wrote %8.8x to %4.4x\n",
b, (((uint32_t) addr) & SPI_OFFSET_MASK));
}
} }
#else /* CONFIG_DEBUG_SPI_FLASH ^^^ enabled vvv NOT enabled */
#define readb_(a) read8(a)
#define readw_(a) read16(a)
#define readl_(a) read32(a)
#define writeb_(val, addr) write8(addr, val)
#define writew_(val, addr) write16(addr, val)
#define writel_(val, addr) write32(addr, val)
#endif /* CONFIG_DEBUG_SPI_FLASH ^^^ NOT enabled */
static void write_reg(const void *value, void *dest, uint32_t size) static void write_reg(const void *value, void *dest, uint32_t size)
{ {
const uint8_t *bvalue = value; const uint8_t *bvalue = value;
@ -441,10 +443,10 @@ static int spi_setup_offset(spi_transaction *trans)
* *
* Return the last read status value on success or -1 on failure. * Return the last read status value on success or -1 on failure.
*/ */
static int ich_status_poll(u16 bitmask, int wait_til_set) static int ich_status_poll(uint16_t bitmask, int wait_til_set)
{ {
int timeout = 40000; /* This will result in 400 ms */ int timeout = 40000; /* This will result in 400 ms */
u16 status = 0; uint16_t status = 0;
while (timeout--) { while (timeout--) {
status = readw_(cntlr.status); status = readw_(cntlr.status);