GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd/stoneyridge/southbridge.c: Change comparison order 

Comparison should place the constant on the right side. Southbridge.c has 6
instances where the opposite happens. Reverse the order of six comparisons
to eliminate checkpatch warnings:
WARNING: Comparisons should place the constant on the right side of the test

BUG=b:117656929
TEST=Build grunt.

Change-Id: I94f17b81f845fa94599f93c0be1144ffcb8e4165
Signed-off-by: Richard Spiegel <richard.spiegel@silverbackltd.com>
Reviewed-on: https://review.coreboot.org/29153
Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>
Reviewed-by: Martin Roth <martinroth@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Richard Spiegel 2018-10-16 13:53:05 -07:00 committed by Patrick Georgi
parent d46bb6bdf0
commit bdd272a951
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/soc/amd/stoneyridge/southbridge.c
View File

@ -53,22 +53,22 @@ const static struct stoneyridge_aoac aoac_devs[] = {
static int is_sata_config(void) static int is_sata_config(void)
{ {
return !((CONFIG_STONEYRIDGE_SATA_MODE == SataNativeIde) return !((SataNativeIde == CONFIG_STONEYRIDGE_SATA_MODE)
|| (CONFIG_STONEYRIDGE_SATA_MODE == SataLegacyIde)); || (SataLegacyIde == CONFIG_STONEYRIDGE_SATA_MODE));
} }
static inline int sb_sata_enable(void) static inline int sb_sata_enable(void)
{ {
/* True if IDE or AHCI. */ /* True if IDE or AHCI. */
return (CONFIG_STONEYRIDGE_SATA_MODE == SataNativeIde) || return (SataNativeIde == CONFIG_STONEYRIDGE_SATA_MODE) ||
(CONFIG_STONEYRIDGE_SATA_MODE == SataAhci); (SataAhci == CONFIG_STONEYRIDGE_SATA_MODE);
} }
static inline int sb_ide_enable(void) static inline int sb_ide_enable(void)
{ {
/* True if IDE or LEGACY IDE. */ /* True if IDE or LEGACY IDE. */
return (CONFIG_STONEYRIDGE_SATA_MODE == SataNativeIde) || return (SataNativeIde == CONFIG_STONEYRIDGE_SATA_MODE) ||
(CONFIG_STONEYRIDGE_SATA_MODE == SataLegacyIde); (SataLegacyIde == CONFIG_STONEYRIDGE_SATA_MODE);
} }
void SetFchResetParams(FCH_RESET_INTERFACE *params) void SetFchResetParams(FCH_RESET_INTERFACE *params)