GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/alderlake: Use Kconfigs for Descriptor Region 

The patch uses Kconfigs for Descriptor Region and Descriptor Region
size instead of locally defined macros

TEST=Build and boot Brya board

Signed-off-by: Sridhar Siricilla <sridhar.siricilla@intel.com>
Change-Id: I3f9461c8604383f995a4438f45286b14fb94deaa
Reviewed-on: https://review.coreboot.org/c/coreboot/+/62264
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Maulik V Vaghela <maulik.v.vaghela@intel.com>
Reviewed-by: Krishna P Bhat D <krishna.p.bhat.d@intel.com>
This commit is contained in:
Sridhar Siricilla 2022-02-23 12:37:11 +05:30 committed by Felix Held
parent b24c528e46
commit be082fe9f4
1 changed files with 8 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/soc/intel/alderlake/bootblock/pmc_descriptor.c
View File

@ -11,8 +11,6 @@
#include <soc/bootblock.h> #include <soc/bootblock.h>
#include <types.h> #include <types.h>
#define SI_DESC_REGION "SI_DESC"
#define SI_DESC_REGION_SZ 4096
#define PMC_DESC_7_BYTE3 0xc32 #define PMC_DESC_7_BYTE3 0xc32
/* Flash Master 1 : HOST/BIOS */ /* Flash Master 1 : HOST/BIOS */
@ -44,18 +42,19 @@ static int is_descriptor_writeable(uint8_t *desc)
/* It updates PMC Descriptor in the Descriptor Region */ /* It updates PMC Descriptor in the Descriptor Region */
void configure_pmc_descriptor(void) void configure_pmc_descriptor(void)
{ {
uint8_t si_desc_buf[SI_DESC_REGION_SZ]; uint8_t si_desc_buf[CONFIG_SI_DESC_REGION_SZ];
struct region_device desc_rdev; struct region_device desc_rdev;
if (cpu_get_cpuid() != CPUID_ALDERLAKE_A0) if (cpu_get_cpuid() != CPUID_ALDERLAKE_A0)
return; return;
if (fmap_locate_area_as_rdev_rw(SI_DESC_REGION, &desc_rdev) < 0) { if (fmap_locate_area_as_rdev_rw(CONFIG_SI_DESC_REGION, &desc_rdev) < 0) {
printk(BIOS_ERR, "Failed to locate %s in the FMAP\n", SI_DESC_REGION); printk(BIOS_ERR, "Failed to locate %s in the FMAP\n", CONFIG_SI_DESC_REGION);
return; return;
} }
if (rdev_readat(&desc_rdev, si_desc_buf, 0, SI_DESC_REGION_SZ) != SI_DESC_REGION_SZ) { if (rdev_readat(&desc_rdev, si_desc_buf, 0, CONFIG_SI_DESC_REGION_SZ) !=
CONFIG_SI_DESC_REGION_SZ) {
printk(BIOS_ERR, "Failed to read Descriptor Region from SPI Flash\n"); printk(BIOS_ERR, "Failed to read Descriptor Region from SPI Flash\n");
return; return;
} }
@ -70,13 +69,13 @@ void configure_pmc_descriptor(void)
si_desc_buf[PMC_DESC_7_BYTE3] = 0x44; si_desc_buf[PMC_DESC_7_BYTE3] = 0x44;
if (rdev_eraseat(&desc_rdev, 0, SI_DESC_REGION_SZ) != SI_DESC_REGION_SZ) { if (rdev_eraseat(&desc_rdev, 0, CONFIG_SI_DESC_REGION_SZ) != CONFIG_SI_DESC_REGION_SZ) {
printk(BIOS_ERR, "Failed to erase Descriptor Region area\n"); printk(BIOS_ERR, "Failed to erase Descriptor Region area\n");
return; return;
} }
if (rdev_writeat(&desc_rdev, si_desc_buf, 0, SI_DESC_REGION_SZ) if (rdev_writeat(&desc_rdev, si_desc_buf, 0, CONFIG_SI_DESC_REGION_SZ)
!= SI_DESC_REGION_SZ) { != CONFIG_SI_DESC_REGION_SZ) {
printk(BIOS_ERR, "Failed to update Descriptor Region\n"); printk(BIOS_ERR, "Failed to update Descriptor Region\n");
return; return;
} }