GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/*: Report mp_init errors 

* Increase log level from ERR to CRITICAL in run_ap_work().
* Print or return errors if mp_run_on_all_cpus() failed.

Tested on Supermicro X11SSH-TF.

Change-Id: I740505e3b6a46ebb3311d0e6b9669e7f929f9ab9
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/34586
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
This commit is contained in:
Patrick Rudolph 2019-07-26 14:22:09 +02:00 committed by Patrick Rudolph
parent 09370df845
commit be207b1098
3 changed files with 13 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/cpu/x86/mp_init.c
View File

@ -910,7 +910,7 @@ static int run_ap_work(struct mp_callback *val, long expire_us)
return 0;
} while (expire_us <= 0 || !stopwatch_expired(&sw));
printk(BIOS_ERR, "AP call expired. %d/%d CPUs accepted.\n",
printk(BIOS_CRIT, "CIRTICAL ERROR: AP call expired. %d/%d CPUs accepted.\n",
cpus_accepted, global_num_aps);
return -1;
}

8
src/soc/amd/common/block/pi/def_callouts.c
View File

@ -220,8 +220,8 @@ AGESA_STATUS agesa_RunFuncOnAp(uint32_t Func, uintptr_t Data, void *ConfigPtr)
agesadata.Func = Func;
agesadata.Data = Data;
agesadata.ConfigPtr = ConfigPtr;
mp_run_on_aps(callout_ap_entry, NULL, MP_RUN_ON_ALL_CPUS,
100 * USECS_PER_MSEC);
if (mp_run_on_aps(callout_ap_entry, NULL, MP_RUN_ON_ALL_CPUS, 100 * USECS_PER_MSEC))
return AGESA_ERROR;
return AGESA_SUCCESS;
}
@ -234,8 +234,8 @@ AGESA_STATUS agesa_RunFcnOnAllAps(uint32_t Func, uintptr_t Data,
agesadata.Func = Func;
agesadata.Data = Data;
agesadata.ConfigPtr = ConfigPtr;
mp_run_on_aps(callout_ap_entry, NULL, MP_RUN_ON_ALL_CPUS,
100 * USECS_PER_MSEC);
if (mp_run_on_aps(callout_ap_entry, NULL, MP_RUN_ON_ALL_CPUS, 100 * USECS_PER_MSEC))
return AGESA_ERROR;
return AGESA_SUCCESS;
}

11
src/soc/intel/skylake/cpu.c
View File

@ -476,6 +476,8 @@ static void fc_lock_configure(void *unused)
static void post_mp_init(void)
{
int ret = 0;
/* Set Max Ratio */
cpu_set_max_ratio();
@ -489,11 +491,14 @@ static void post_mp_init(void)
if (CONFIG(HAVE_SMI_HANDLER))
smm_lock();
mp_run_on_all_cpus(vmx_configure, NULL, 2 * USECS_PER_MSEC);
ret |= mp_run_on_all_cpus(vmx_configure, NULL, 2 * USECS_PER_MSEC);
mp_run_on_all_cpus(sgx_configure, NULL, 14 * USECS_PER_MSEC);
ret |= mp_run_on_all_cpus(sgx_configure, NULL, 14 * USECS_PER_MSEC);
mp_run_on_all_cpus(fc_lock_configure, NULL, 2 * USECS_PER_MSEC);
ret |= mp_run_on_all_cpus(fc_lock_configure, NULL, 2 * USECS_PER_MSEC);
if (ret)
printk(BIOS_CRIT, "CRITICAL ERROR: MP post init failed\n");
}
static const struct mp_ops mp_ops = {