soc/*: Report mp_init errors
* Increase log level from ERR to CRITICAL in run_ap_work(). * Print or return errors if mp_run_on_all_cpus() failed. Tested on Supermicro X11SSH-TF. Change-Id: I740505e3b6a46ebb3311d0e6b9669e7f929f9ab9 Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/34586 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Furquan Shaikh <furquan@google.com>
This commit is contained in:
parent
09370df845
commit
be207b1098
|
@ -910,7 +910,7 @@ static int run_ap_work(struct mp_callback *val, long expire_us)
|
||||||
return 0;
|
return 0;
|
||||||
} while (expire_us <= 0 || !stopwatch_expired(&sw));
|
} while (expire_us <= 0 || !stopwatch_expired(&sw));
|
||||||
|
|
||||||
printk(BIOS_ERR, "AP call expired. %d/%d CPUs accepted.\n",
|
printk(BIOS_CRIT, "CIRTICAL ERROR: AP call expired. %d/%d CPUs accepted.\n",
|
||||||
cpus_accepted, global_num_aps);
|
cpus_accepted, global_num_aps);
|
||||||
return -1;
|
return -1;
|
||||||
}
|
}
|
||||||
|
|
|
@ -220,8 +220,8 @@ AGESA_STATUS agesa_RunFuncOnAp(uint32_t Func, uintptr_t Data, void *ConfigPtr)
|
||||||
agesadata.Func = Func;
|
agesadata.Func = Func;
|
||||||
agesadata.Data = Data;
|
agesadata.Data = Data;
|
||||||
agesadata.ConfigPtr = ConfigPtr;
|
agesadata.ConfigPtr = ConfigPtr;
|
||||||
mp_run_on_aps(callout_ap_entry, NULL, MP_RUN_ON_ALL_CPUS,
|
if (mp_run_on_aps(callout_ap_entry, NULL, MP_RUN_ON_ALL_CPUS, 100 * USECS_PER_MSEC))
|
||||||
100 * USECS_PER_MSEC);
|
return AGESA_ERROR;
|
||||||
|
|
||||||
return AGESA_SUCCESS;
|
return AGESA_SUCCESS;
|
||||||
}
|
}
|
||||||
|
@ -234,8 +234,8 @@ AGESA_STATUS agesa_RunFcnOnAllAps(uint32_t Func, uintptr_t Data,
|
||||||
agesadata.Func = Func;
|
agesadata.Func = Func;
|
||||||
agesadata.Data = Data;
|
agesadata.Data = Data;
|
||||||
agesadata.ConfigPtr = ConfigPtr;
|
agesadata.ConfigPtr = ConfigPtr;
|
||||||
mp_run_on_aps(callout_ap_entry, NULL, MP_RUN_ON_ALL_CPUS,
|
if (mp_run_on_aps(callout_ap_entry, NULL, MP_RUN_ON_ALL_CPUS, 100 * USECS_PER_MSEC))
|
||||||
100 * USECS_PER_MSEC);
|
return AGESA_ERROR;
|
||||||
|
|
||||||
return AGESA_SUCCESS;
|
return AGESA_SUCCESS;
|
||||||
}
|
}
|
||||||
|
|
|
@ -476,6 +476,8 @@ static void fc_lock_configure(void *unused)
|
||||||
|
|
||||||
static void post_mp_init(void)
|
static void post_mp_init(void)
|
||||||
{
|
{
|
||||||
|
int ret = 0;
|
||||||
|
|
||||||
/* Set Max Ratio */
|
/* Set Max Ratio */
|
||||||
cpu_set_max_ratio();
|
cpu_set_max_ratio();
|
||||||
|
|
||||||
|
@ -489,11 +491,14 @@ static void post_mp_init(void)
|
||||||
if (CONFIG(HAVE_SMI_HANDLER))
|
if (CONFIG(HAVE_SMI_HANDLER))
|
||||||
smm_lock();
|
smm_lock();
|
||||||
|
|
||||||
mp_run_on_all_cpus(vmx_configure, NULL, 2 * USECS_PER_MSEC);
|
ret |= mp_run_on_all_cpus(vmx_configure, NULL, 2 * USECS_PER_MSEC);
|
||||||
|
|
||||||
mp_run_on_all_cpus(sgx_configure, NULL, 14 * USECS_PER_MSEC);
|
ret |= mp_run_on_all_cpus(sgx_configure, NULL, 14 * USECS_PER_MSEC);
|
||||||
|
|
||||||
mp_run_on_all_cpus(fc_lock_configure, NULL, 2 * USECS_PER_MSEC);
|
ret |= mp_run_on_all_cpus(fc_lock_configure, NULL, 2 * USECS_PER_MSEC);
|
||||||
|
|
||||||
|
if (ret)
|
||||||
|
printk(BIOS_CRIT, "CRITICAL ERROR: MP post init failed\n");
|
||||||
}
|
}
|
||||||
|
|
||||||
static const struct mp_ops mp_ops = {
|
static const struct mp_ops mp_ops = {
|
||||||
|
|
Loading…
Reference in New Issue