From be2f937f1ef51cb791739eae1fc00c441bb06860 Mon Sep 17 00:00:00 2001 From: Arthur Heymans Date: Tue, 16 Mar 2021 16:27:27 +0100 Subject: [PATCH] soc/intel/xeon_sp: Remove bogus SMRAM locking From tests this does not lock down SMRAM and it's also not possible to read back what is written, be it via PCI mmconfig or io ops. The FSP integration can be assumed to be bogus on this point. Change-Id: Ia0526774f7b201d2a3c0eefb578bf0a19dae9212 Signed-off-by: Arthur Heymans Reviewed-on: https://review.coreboot.org/c/coreboot/+/51532 Reviewed-by: Angel Pons Tested-by: build bot (Jenkins) --- src/soc/intel/xeon_sp/cpx/chip.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/soc/intel/xeon_sp/cpx/chip.c b/src/soc/intel/xeon_sp/cpx/chip.c index 3eaf46f1cf..9164b7cbe7 100644 --- a/src/soc/intel/xeon_sp/cpx/chip.c +++ b/src/soc/intel/xeon_sp/cpx/chip.c @@ -182,14 +182,6 @@ static void chip_final(void *data) /* LOCK PAM */ pci_or_config32(pcidev_path_on_root(PCI_DEVFN(0, 0)), 0x80, 1 << 0); - /* - * LOCK SMRAM - * According to the CedarIsland FSP Integration Guide this needs to - * be done with legacy 0xCF8/0xCFC IO ops. - */ - uint8_t reg8 = pci_io_read_config8(PCI_DEV(0, 0, 0), 0x88); - pci_io_write_config8(PCI_DEV(0, 0, 0), 0x88, reg8 | (1 << 4)); - mp_run_on_all_cpus(set_msr_locks, NULL); set_pcu_locks(); set_imc_locks();