GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/jasperlake: Update scs.asl to ASL2.0 syntax 

This change updates scs.asl to use ASL2.0 syntax. This
increases the readability of the ASL code.

TEST=Verified using --timeless option to abuild that the resulting
coreboot.rom is same as without the ASL2.0 syntax changes for wdoo.

Change-Id: Ic1b5f3395a1ea8a3dd2ac6b109f9a5abe65d137f
Signed-off-by: V Sowmya <v.sowmya@intel.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/41862
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-by: Subrata Banik <subrata.banik@intel.com>
This commit is contained in:
V Sowmya 2020-05-28 22:28:25 +05:30 committed by Patrick Georgi
parent 4b3995c25f
commit be63cf46e5
1 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/soc/intel/jasperlake/acpi/scs.asl
View File

@ -37,22 +37,22 @@ Scope (\_SB.PCI0) {
Method(_PS0, 0, Serialized) { Method(_PS0, 0, Serialized) {
Stall (50) // Sleep 50 us Stall (50) // Sleep 50 us
Store(0, PGEN) // Disable PG PGEN = 0 // Disable PG
/* Clear register 0x1C20/0x4820 */ /* Clear register 0x1C20/0x4820 */
SCSC (PID_EMMC) SCSC (PID_EMMC)
/* Set Power State to D0 */ /* Set Power State to D0 */
And (PMCR, 0xFFFC, PMCR) PMCR = PMCR & 0xFFFC
Store (PMCR, TEMP) TEMP = PMCR
} }
Method(_PS3, 0, Serialized) { Method(_PS3, 0, Serialized) {
Store(1, PGEN) // Enable PG PGEN = 1 // Enable PG
/* Set Power State to D3 */ /* Set Power State to D3 */
Or (PMCR, 0x0003, PMCR) PMCR = PMCR | 0x0003
Store (PMCR, TEMP) TEMP = PMCR
} }
Device (CARD) Device (CARD)
@ -90,23 +90,23 @@ Scope (\_SB.PCI0) {
Method (_PS0, 0, Serialized) Method (_PS0, 0, Serialized)
{ {
Store (0, PGEN) /* Disable PG */ PGEN = 0 /* Disable PG */
/* Clear register 0x1C20/0x4820 */ /* Clear register 0x1C20/0x4820 */
SCSC (PID_SDX) SCSC (PID_SDX)
/* Set Power State to D0 */ /* Set Power State to D0 */
And (PMCR, 0xFFFC, PMCR) PMCR = PMCR & 0xFFFC
Store (PMCR, TEMP) TEMP = PMCR
} }
Method (_PS3, 0, Serialized) Method (_PS3, 0, Serialized)
{ {
Store (1, PGEN) /* Enable PG */ PGEN = 1 /* Enable PG */
/* Set Power State to D3 */ /* Set Power State to D3 */
Or (PMCR, 0x0003, PMCR) PMCR = PMCR | 0x0003
Store (PMCR, TEMP) TEMP = PMCR
} }
Device (CARD) Device (CARD)