GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cpu/amd/model_fxx/powernow_acpi.c: Comment out set but unused variable `Start_vid` 

When adding support for PSS object generation for AMD pre Family Fh CPUs
(199c694f) the function `pstates_algorithm` was copied and adapted, but
`Start_vid` is not needed anymore as a static table is used. I’d remove
the variable, but Ron Minnich requested to leave it there for
documentation purposes. So just comment it out.

Change-Id: I3002951d168cade6461941c16d78373c47792e13
Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-on: http://review.coreboot.org/4036
Tested-by: build bot (Jenkins)
Reviewed-by: Rudolf Marek <r.marek@assembler.cz>
This commit is contained in:
Paul Menzel 2013-10-29 20:41:50 +01:00 committed by Rudolf Marek
parent 01d06dc67b
commit be8d23a3b5
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/cpu/amd/model_fxx/powernow_acpi.c
View File

@ -758,7 +758,7 @@ static int pstates_algorithm(u32 pcontrol_blk, u8 plen, u8 onlyBSP)
u16 Pstate_feq[MAXP+1]; u16 Pstate_feq[MAXP+1];
u8 Pstate_vid[MAXP+1]; u8 Pstate_vid[MAXP+1];
u32 Pstate_power[MAXP+1]; u32 Pstate_power[MAXP+1];
u8 Max_fid, Start_fid, Start_vid, Max_vid; u8 Max_fid, Start_fid, Max_vid;
struct cpuid_result cpuid1; struct cpuid_result cpuid1;
/* See if the CPUID(0x80000007) returned EDX[2:1]==11b */ /* See if the CPUID(0x80000007) returned EDX[2:1]==11b */
@ -777,7 +777,7 @@ static int pstates_algorithm(u32 pcontrol_blk, u8 plen, u8 onlyBSP)
Max_fid = (msr.lo & 0x3F0000) >> 16; Max_fid = (msr.lo & 0x3F0000) >> 16;
Max_vid = (msr.hi & 0x3F0000) >> 16; Max_vid = (msr.hi & 0x3F0000) >> 16;
Start_fid = (msr.lo & 0x3F00) >> 8; Start_fid = (msr.lo & 0x3F00) >> 8;
Start_vid = (msr.hi & 0x3F00) >> 8; /* Start_vid = (msr.hi & 0x3F00) >> 8; */
cmp_cap = cmp_cap =
(pci_read_config16(dev_find_slot(0, PCI_DEVFN(0x18, 3)), 0xE8) & (pci_read_config16(dev_find_slot(0, PCI_DEVFN(0x18, 3)), 0xE8) &