GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/common/cse: Late sending EOP msg if !HECI_DISABLE_USING_SMM 

Pushing EOP msg post FSP notify helps to save ~30ms+ boot time across
various warm reboots.

This patch ensures late sending EOP msg when function disabling of CSE
is no longer a requirement.

BUG=b:200644229
TEST=Able to save ~30ms+ of boot time

Without this code change EOP sending timestamp as below:

943:after sending EOP to ME                     1,248,328(61,954))

With this code change EOP sending timestamp as below:

943:after sending EOP to ME                     1,231,660 (2,754)

Change-Id: I2b78a1c07803aacfb34dce9e94b2a05a2491aabc
Signed-off-by: Subrata Banik <subrata.banik@intel.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/57806
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Maulik V Vaghela <maulik.v.vaghela@intel.com>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
This commit is contained in:
Subrata Banik 2021-09-21 21:00:16 +05:30
parent a834a6eede
commit bee4bb5f0d
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/soc/intel/common/block/cse/cse_eop.c
View File

@ -185,10 +185,15 @@ static void set_cse_end_of_post(void *unused)
/* /*
* Ideally, to give coreboot maximum flexibility, sending EOP would be done as * Ideally, to give coreboot maximum flexibility, sending EOP would be done as
* late possible, just before loading the payload, which would be BS_ON_EXIT * late possible. If HECI_DISABLE_USING_SMM is selected, then sending EOP must
* here, but the platforms this is currently supported for all select * be performed before the HECI bus is disabled, so these boards use
* HECI_DISABLE_USING_SMM, which runs in BS_ON_EXIT. Because sending EOP * BS_PAYLOAD_LOAD, which happens before the HECI_DISABLE_USING_SMM Kconfig takes
* requires HECI to be up, and it is not trivial to control the order in which * effect (EOP is sent using the HECI bus).
* these callbacks are issued, it is called on BS_ON_ENTRY. * Otherwise, EOP can be pushed a little later, and can be performed in
* BS_PAYLOAD_BOOT instead.
*/ */
#if !CONFIG(HECI_DISABLE_USING_SMM)
BOOT_STATE_INIT_ENTRY(BS_PAYLOAD_BOOT, BS_ON_ENTRY, set_cse_end_of_post, NULL);
#else
BOOT_STATE_INIT_ENTRY(BS_PAYLOAD_LOAD, BS_ON_ENTRY, set_cse_end_of_post, NULL); BOOT_STATE_INIT_ENTRY(BS_PAYLOAD_LOAD, BS_ON_ENTRY, set_cse_end_of_post, NULL);
#endif