mb/google/volteer: Move hda device enabling to override tree

This change moves the hda device enabling from baseboard device tree
to override tree for the variants that did not provide any hda
specific nodes. This ensures that the probe statements are correctly
selected by the variant depending upon the configurations it
supports.

Change-Id: Ib7b36468f17fbd65eb3d7d9355fcf78148aeb44a
Signed-off-by: Furquan Shaikh <furquan@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/57123
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Reviewed-by: Nick Vaccaro <nvaccaro@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Furquan Shaikh 2021-08-24 13:16:35 -07:00 committed by Tim Wawrzynczak
parent ae20d4c78f
commit bf42db6eb7
12 changed files with 80 additions and 7 deletions

View File

@ -526,12 +526,5 @@ chip soc/intel/tigerlake
device pnp 0c09.0 on end device pnp 0c09.0 on end
end end
end end
device ref hda on
probe AUDIO MAX98357_ALC5682I_I2S
probe AUDIO MAX98373_ALC5682I_I2S
probe AUDIO MAX98373_ALC5682_SNDW
probe AUDIO MAX98373_ALC5682I_I2S_UP4
probe AUDIO MAX98360_ALC5682I_I2S
end
end end
end end

View File

@ -184,6 +184,13 @@ chip soc/intel/tigerlake
device pnp 0c09.0 on end device pnp 0c09.0 on end
end end
end end
device ref hda on
probe AUDIO MAX98357_ALC5682I_I2S
probe AUDIO MAX98373_ALC5682I_I2S
probe AUDIO MAX98373_ALC5682_SNDW
probe AUDIO MAX98373_ALC5682I_I2S_UP4
probe AUDIO MAX98360_ALC5682I_I2S
end
device ref pcie_rp9 on device ref pcie_rp9 on
chip soc/intel/common/block/pcie/rtd3 chip soc/intel/common/block/pcie/rtd3
register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B2)" register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B2)"

View File

@ -209,6 +209,13 @@ chip soc/intel/tigerlake
device pnp 0c09.0 on end device pnp 0c09.0 on end
end end
end end
device ref hda on
probe AUDIO MAX98357_ALC5682I_I2S
probe AUDIO MAX98373_ALC5682I_I2S
probe AUDIO MAX98373_ALC5682_SNDW
probe AUDIO MAX98373_ALC5682I_I2S_UP4
probe AUDIO MAX98360_ALC5682I_I2S
end
device ref pcie_rp9 on device ref pcie_rp9 on
chip soc/intel/common/block/pcie/rtd3 chip soc/intel/common/block/pcie/rtd3
register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B2)" register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B2)"

View File

@ -190,6 +190,13 @@ chip soc/intel/tigerlake
device pnp 0c09.0 on end device pnp 0c09.0 on end
end end
end end
device ref hda on
probe AUDIO MAX98357_ALC5682I_I2S
probe AUDIO MAX98373_ALC5682I_I2S
probe AUDIO MAX98373_ALC5682_SNDW
probe AUDIO MAX98373_ALC5682I_I2S_UP4
probe AUDIO MAX98360_ALC5682I_I2S
end
device ref pcie_rp9 on device ref pcie_rp9 on
chip soc/intel/common/block/pcie/rtd3 chip soc/intel/common/block/pcie/rtd3
register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B2)" register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B2)"

View File

@ -186,6 +186,15 @@ chip soc/intel/tigerlake
device pnp 0c09.0 on end device pnp 0c09.0 on end
end end
end end
device ref hda on
probe AUDIO MAX98357_ALC5682I_I2S
probe AUDIO MAX98373_ALC5682I_I2S
probe AUDIO MAX98373_ALC5682_SNDW
probe AUDIO MAX98373_ALC5682I_I2S_UP4
probe AUDIO MAX98360_ALC5682I_I2S
end
device ref pcie_rp9 on device ref pcie_rp9 on
chip soc/intel/common/block/pcie/rtd3 chip soc/intel/common/block/pcie/rtd3
register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B2)" register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B2)"

View File

@ -268,6 +268,13 @@ chip soc/intel/tigerlake
device pnp 0c09.0 on end device pnp 0c09.0 on end
end end
end end
device ref hda on
probe AUDIO MAX98357_ALC5682I_I2S
probe AUDIO MAX98373_ALC5682I_I2S
probe AUDIO MAX98373_ALC5682_SNDW
probe AUDIO MAX98373_ALC5682I_I2S_UP4
probe AUDIO MAX98360_ALC5682I_I2S
end
device ref pcie_rp9 on device ref pcie_rp9 on
chip soc/intel/common/block/pcie/rtd3 chip soc/intel/common/block/pcie/rtd3
register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_A22)" register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_A22)"

View File

@ -132,6 +132,13 @@ chip soc/intel/tigerlake
device pnp 0c09.0 on end device pnp 0c09.0 on end
end end
end end
device ref hda on
probe AUDIO MAX98357_ALC5682I_I2S
probe AUDIO MAX98373_ALC5682I_I2S
probe AUDIO MAX98373_ALC5682_SNDW
probe AUDIO MAX98373_ALC5682I_I2S_UP4
probe AUDIO MAX98360_ALC5682I_I2S
end
device ref pcie_rp9 on device ref pcie_rp9 on
chip soc/intel/common/block/pcie/rtd3 chip soc/intel/common/block/pcie/rtd3
register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B2)" register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B2)"

View File

@ -134,6 +134,13 @@ chip soc/intel/tigerlake
device pnp 0c09.0 on end device pnp 0c09.0 on end
end end
end end
device ref hda on
probe AUDIO MAX98357_ALC5682I_I2S
probe AUDIO MAX98373_ALC5682I_I2S
probe AUDIO MAX98373_ALC5682_SNDW
probe AUDIO MAX98373_ALC5682I_I2S_UP4
probe AUDIO MAX98360_ALC5682I_I2S
end
device ref pmc hidden device ref pmc hidden
# The pmc_mux chip driver is a placeholder for the # The pmc_mux chip driver is a placeholder for the
# PMC.MUX device in the ACPI hierarchy. # PMC.MUX device in the ACPI hierarchy.

View File

@ -2,6 +2,14 @@ chip soc/intel/tigerlake
register "SaGv" = "SaGv_Disabled" register "SaGv" = "SaGv_Disabled"
device domain 0 on device domain 0 on
device ref hda on
probe AUDIO MAX98357_ALC5682I_I2S
probe AUDIO MAX98373_ALC5682I_I2S
probe AUDIO MAX98373_ALC5682_SNDW
probe AUDIO MAX98373_ALC5682I_I2S_UP4
probe AUDIO MAX98360_ALC5682I_I2S
end
device ref i2c1 on device ref i2c1 on
chip drivers/i2c/hid chip drivers/i2c/hid
register "generic.hid" = ""GDIX0000"" register "generic.hid" = ""GDIX0000""

View File

@ -94,6 +94,13 @@ chip soc/intel/tigerlake
device pnp 0c09.0 on end device pnp 0c09.0 on end
end end
end end
device ref hda on
probe AUDIO MAX98357_ALC5682I_I2S
probe AUDIO MAX98373_ALC5682I_I2S
probe AUDIO MAX98373_ALC5682_SNDW
probe AUDIO MAX98373_ALC5682I_I2S_UP4
probe AUDIO MAX98360_ALC5682I_I2S
end
device ref pcie_rp9 on device ref pcie_rp9 on
chip soc/intel/common/block/pcie/rtd3 chip soc/intel/common/block/pcie/rtd3
register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B2)" register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B2)"

View File

@ -131,6 +131,13 @@ chip soc/intel/tigerlake
device pnp 0c09.0 on end device pnp 0c09.0 on end
end end
end end
device ref hda on
probe AUDIO MAX98357_ALC5682I_I2S
probe AUDIO MAX98373_ALC5682I_I2S
probe AUDIO MAX98373_ALC5682_SNDW
probe AUDIO MAX98373_ALC5682I_I2S_UP4
probe AUDIO MAX98360_ALC5682I_I2S
end
device ref pcie_rp9 on device ref pcie_rp9 on
chip soc/intel/common/block/pcie/rtd3 chip soc/intel/common/block/pcie/rtd3
register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B2)" register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B2)"

View File

@ -223,6 +223,13 @@ chip soc/intel/tigerlake
device pnp 0c09.0 on end device pnp 0c09.0 on end
end end
end end
device ref hda on
probe AUDIO MAX98357_ALC5682I_I2S
probe AUDIO MAX98373_ALC5682I_I2S
probe AUDIO MAX98373_ALC5682_SNDW
probe AUDIO MAX98373_ALC5682I_I2S_UP4
probe AUDIO MAX98360_ALC5682I_I2S
end
device ref pcie_rp9 on device ref pcie_rp9 on
chip soc/intel/common/block/pcie/rtd3 chip soc/intel/common/block/pcie/rtd3
register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B2)" register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B2)"