sb/intel/sandybridge/early_pch: Make DMI init more readable

Add a few comments and use known register values.
Based on the "2nd Generation Intel® Core™ Processor Family Mobile"
datasheet and the existing serialice trace.

Tested on Lenovo T520 (Intel Sandy Bridge).
Still boots to GNU/Linux.

Change-Id: I404515b77a22324f55581f117d79630be4ba64dd
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32071
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Patrick Rudolph 2019-03-25 17:05:20 +01:00 committed by Patrick Georgi
parent 25b35d317e
commit bf7435087e
3 changed files with 148 additions and 71 deletions

View File

@ -175,12 +175,23 @@ enum platform_type {
#define DMIPVCCCTL 0x00c /* 16bit */ #define DMIPVCCCTL 0x00c /* 16bit */
#define DMIVC0RCAP 0x010 /* 32bit */ #define DMIVC0RCAP 0x010 /* 32bit */
#define DMIVC0RCTL0 0x014 /* 32bit */ #define DMIVC0RCTL 0x014 /* 32bit */
#define DMIVC0RSTS 0x01a /* 16bit */ #define DMIVC0RSTS 0x01a /* 16bit */
#define VC0NP 0x2
#define DMIVC1RCAP 0x01c /* 32bit */ #define DMIVC1RCAP 0x01c /* 32bit */
#define DMIVC1RCTL 0x020 /* 32bit */ #define DMIVC1RCTL 0x020 /* 32bit */
#define DMIVC1RSTS 0x026 /* 16bit */ #define DMIVC1RSTS 0x026 /* 16bit */
#define VC1NP 0x2
#define DMIVCPRCTL 0x02c /* 32bit */
#define DMIVCPRSTS 0x032 /* 16bit */
#define VCPNP 0x2
#define DMIVCMRCTL 0x0038 /* 32 bit */
#define DMIVCMRSTS 0x003e /* 16 bit */
#define VCMNP 0x2
#define DMILE1D 0x050 /* 32bit */ #define DMILE1D 0x050 /* 32bit */
#define DMILE1A 0x058 /* 64bit */ #define DMILE1A 0x058 /* 64bit */
@ -190,7 +201,7 @@ enum platform_type {
#define DMILCAP 0x084 /* 32bit */ #define DMILCAP 0x084 /* 32bit */
#define DMILCTL 0x088 /* 16bit */ #define DMILCTL 0x088 /* 16bit */
#define DMILSTS 0x08a /* 16bit */ #define DMILSTS 0x08a /* 16bit */
#define TXTRN (1 << 11)
#define DMICTL1 0x0f0 /* 32bit */ #define DMICTL1 0x0f0 /* 32bit */
#define DMICTL2 0x0fc /* 32bit */ #define DMICTL2 0x0fc /* 32bit */

View File

@ -20,6 +20,7 @@
#include <device/pci_def.h> #include <device/pci_def.h>
#include <southbridge/intel/common/gpio.h> #include <southbridge/intel/common/gpio.h>
#include <southbridge/intel/common/pmbase.h> #include <southbridge/intel/common/pmbase.h>
#include <console/console.h>
/* For DMI bar. */ /* For DMI bar. */
#include <northbridge/intel/sandybridge/sandybridge.h> #include <northbridge/intel/sandybridge/sandybridge.h>
@ -68,36 +69,29 @@ write_iobp(u32 address, u32 val)
read8(DEFAULT_RCBA + IOBPS); // call wait_iobp() instead here? read8(DEFAULT_RCBA + IOBPS); // call wait_iobp() instead here?
} }
static void static void
init_dmi (void) init_dmi (void)
{ {
volatile u32 tmp;
int i; int i;
write32 (DEFAULT_DMIBAR + 0x0914, DMIBAR32(0x0914) |= 0x80000000;
read32 (DEFAULT_DMIBAR + 0x0914) | 0x80000000); DMIBAR32(0x0934) |= 0x80000000;
write32 (DEFAULT_DMIBAR + 0x0934,
read32 (DEFAULT_DMIBAR + 0x0934) | 0x80000000); for (i = 0; i < 4; i++) {
for (i = 0; i < 4; i++) DMIBAR32(0x0a00 + (i << 4)) &= 0xf3ffffff;
{ DMIBAR32(0x0a04 + (i << 4)) |= 0x800;
write32 (DEFAULT_DMIBAR + 0x0a00 + (i << 4),
read32 (DEFAULT_DMIBAR + 0x0a00 + (i << 4)) & 0xf3ffffff);
write32 (DEFAULT_DMIBAR + 0x0a04 + (i << 4),
read32 (DEFAULT_DMIBAR + 0x0a04 + (i << 4)) | 0x800);
} }
write32 (DEFAULT_DMIBAR + 0x0c30, (read32 (DEFAULT_DMIBAR + 0x0c30) DMIBAR32(0x0c30) = (DMIBAR32(0x0c30) & 0xfffffff) | 0x40000000;
& 0xfffffff) | 0x40000000);
for (i = 0; i < 2; i++) for (i = 0; i < 2; i++) {
{ DMIBAR32(0x0904 + (i << 5)) &= 0xfe3fffff;
write32 (DEFAULT_DMIBAR + 0x0904 + (i << 5), DMIBAR32(0x090c + (i << 5)) &= 0xfff1ffff;
read32 (DEFAULT_DMIBAR + 0x0904 + (i << 5)) & 0xfe3fffff);
write32 (DEFAULT_DMIBAR + 0x090c + (i << 5),
read32 (DEFAULT_DMIBAR + 0x090c + (i << 5)) & 0xfff1ffff);
} }
write32 (DEFAULT_DMIBAR + 0x090c,
read32 (DEFAULT_DMIBAR + 0x090c) & 0xfe1fffff); DMIBAR32(0x090c) &= 0xfe1fffff;
write32 (DEFAULT_DMIBAR + 0x092c, DMIBAR32(0x092c) &= 0xfe1fffff;
read32 (DEFAULT_DMIBAR + 0x092c) & 0xfe1fffff);
read32 (DEFAULT_DMIBAR + 0x0904); // !!! = 0x7a1842ec read32 (DEFAULT_DMIBAR + 0x0904); // !!! = 0x7a1842ec
write32 (DEFAULT_DMIBAR + 0x0904, 0x7a1842ec); write32 (DEFAULT_DMIBAR + 0x0904, 0x7a1842ec);
read32 (DEFAULT_DMIBAR + 0x090c); // !!! = 0x00000208 read32 (DEFAULT_DMIBAR + 0x090c); // !!! = 0x00000208
@ -226,33 +220,54 @@ init_dmi (void)
write32 (DEFAULT_DMIBAR + 0x0934, 0x98200280); write32 (DEFAULT_DMIBAR + 0x0934, 0x98200280);
read32 (DEFAULT_DMIBAR + 0x022c); // !!! = 0x00c26460 read32 (DEFAULT_DMIBAR + 0x022c); // !!! = 0x00c26460
write32 (DEFAULT_DMIBAR + 0x022c, 0x00c2403c); write32 (DEFAULT_DMIBAR + 0x022c, 0x00c2403c);
read8 (DEFAULT_RCBA + 0x21a4); // !!! = 0x42
read32 (DEFAULT_RCBA + 0x21a4); // !!! = 0x00012c42 /* Link Capabilities Register */
read32 (DEFAULT_RCBA + 0x2340); // !!! = 0x0013001b RCBA32(0x21a4) = (RCBA32(0x21a4) & ~0x3fc00) |
write32 (DEFAULT_RCBA + 0x2340, 0x003a001b); (3 << 10) | // L0s and L1 entry supported
read8 (DEFAULT_RCBA + 0x21b0); // !!! = 0x01 (2 << 12) | // L0s 128 ns to less than 256 ns
write8 (DEFAULT_RCBA + 0x21b0, 0x02); (2 << 15); // L1 2 us to less than 4 us
read32 (DEFAULT_DMIBAR + 0x0084); // !!! = 0x0041ac41
write32 (DEFAULT_DMIBAR + 0x0084, 0x0041ac42);
read8 (DEFAULT_DMIBAR + 0x0088); // !!! = 0x00
write8 (DEFAULT_DMIBAR + 0x0088, 0x20);
read16 (DEFAULT_DMIBAR + 0x008a); // !!! = 0x0041
read8 (DEFAULT_DMIBAR + 0x0088); // !!! = 0x00
write8 (DEFAULT_DMIBAR + 0x0088, 0x20);
read16 (DEFAULT_DMIBAR + 0x008a); // !!! = 0x0042
read16 (DEFAULT_DMIBAR + 0x008a); // !!! = 0x0042
read32 (DEFAULT_DMIBAR + 0x0014); // !!! = 0x8000007f RCBA32(0x2340) = (RCBA32(0x2340) & ~0xff0000) | (0x3a << 16);
write32 (DEFAULT_DMIBAR + 0x0014, 0x80000019); RCBA8(0x21b0) = (RCBA8(0x21b0) & ~0xf) | 2;
read32 (DEFAULT_DMIBAR + 0x0020); // !!! = 0x01000000
write32 (DEFAULT_DMIBAR + 0x0020, 0x81000022); /* Write once settings. */
read32 (DEFAULT_DMIBAR + 0x002c); // !!! = 0x02000000 DMIBAR32(DMILCAP) = (DMIBAR32(DMILCAP) & ~0x3f00f) |
write32 (DEFAULT_DMIBAR + 0x002c, 0x82000044); (2 << 0) | // 5GT/s
read32 (DEFAULT_DMIBAR + 0x0038); // !!! = 0x07000080 (2 << 12) | // L0s 128 ns to less than 256 ns
write32 (DEFAULT_DMIBAR + 0x0038, 0x87000080); (2 << 15); // L1 2 us to less than 4 us
read8 (DEFAULT_DMIBAR + 0x0004); // !!! = 0x00
write8 (DEFAULT_DMIBAR + 0x0004, 0x01); DMIBAR8(DMILCTL) |= 0x20; // Retrain link
while (DMIBAR16(DMILSTS) & TXTRN)
;
DMIBAR8(DMILCTL) |= 0x20; // Retrain link
while (DMIBAR16(DMILSTS) & TXTRN)
;
const u8 w = (DMIBAR16(DMILSTS) >> 4) & 0x1f;
const u16 t = (DMIBAR16(DMILSTS) & 0xf) * 2500;
printk(BIOS_DEBUG, "DMI: Running at X%x @ %dMT/s\n", w, t);
/*
* Virtual Channel resources must match settings in RCBA!
*
* Channel Vp and Vm are documented in
* "Desktop 4th Generation Intel Core Processor Family, Desktop Intel
* Pentium Processor Family, and Desktop Intel Celeron Processor Family
* Vol. 2"
*/
/* Channel 0: Enable, Set ID to 0, map TC0 and TC3 and TC4 to VC0. */
DMIBAR32(DMIVC0RCTL) = (1 << 31) | (0 << 24) | (0x0c << 1) | 1;
/* Channel 1: Enable, Set ID to 1, map TC1 and TC5 to VC1. */
DMIBAR32(DMIVC1RCTL) = (1 << 31) | (1 << 24) | (0x11 << 1);
/* Channel p: Enable, Set ID to 2, map TC2 and TC6 to VCp */
DMIBAR32(DMIVCPRCTL) = (1 << 31) | (2 << 24) | (0x22 << 1);
/* Channel m: Enable, Set ID to 0, map TC7 to VCm */
DMIBAR32(DMIVCMRCTL) = (1 << 31) | (7 << 24) | (0x40 << 1);
/* Set Extended VC Count (EVCC) to 1 as Channel 1 is active. */
DMIBAR8(DMIPVCCAP1) |= 1;
read32 (DEFAULT_RCBA + 0x0050); // !!! = 0x01200654 read32 (DEFAULT_RCBA + 0x0050); // !!! = 0x01200654
write32 (DEFAULT_RCBA + 0x0050, 0x01200654); write32 (DEFAULT_RCBA + 0x0050, 0x01200654);
@ -261,27 +276,76 @@ init_dmi (void)
read32 (DEFAULT_RCBA + 0x0050); // !!! = 0x012a0654 read32 (DEFAULT_RCBA + 0x0050); // !!! = 0x012a0654
read8 (DEFAULT_RCBA + 0x1114); // !!! = 0x00 read8 (DEFAULT_RCBA + 0x1114); // !!! = 0x00
write8 (DEFAULT_RCBA + 0x1114, 0x05); write8 (DEFAULT_RCBA + 0x1114, 0x05);
read32 (DEFAULT_RCBA + 0x2014); // !!! = 0x80000011
write32 (DEFAULT_RCBA + 0x2014, 0x80000019); /*
read32 (DEFAULT_RCBA + 0x2020); // !!! = 0x00000000 * Virtual Channel resources must match settings in DMIBAR!
write32 (DEFAULT_RCBA + 0x2020, 0x81000022); *
read32 (DEFAULT_RCBA + 0x2020); // !!! = 0x81000022 * Some of the following settings are taken from
read32 (DEFAULT_RCBA + 0x2030); // !!! = 0x00000000 * "Intel Core i5-600, i3-500 Desktop Processor Series and Intel
write32 (DEFAULT_RCBA + 0x2030, 0x82000044); * Pentium Desktop Processor 6000 Series Vol. 2" datasheet and
read32 (DEFAULT_RCBA + 0x2030); // !!! = 0x82000044 * serialice traces.
read32 (DEFAULT_RCBA + 0x2040); // !!! = 0x00000000 */
write32 (DEFAULT_RCBA + 0x2040, 0x87000080);
read32 (DEFAULT_RCBA + 0x0050); // !!! = 0x012a0654 /* Virtual Channel 0 Resource Control Register.
write32 (DEFAULT_RCBA + 0x0050, 0x812a0654); * Enable channel.
read32 (DEFAULT_RCBA + 0x0050); // !!! = 0x812a0654 * Set Virtual Channel Identifier.
read16 (DEFAULT_RCBA + 0x201a); // !!! = 0x0000 * Map TC0 and TC3 and TC4 to VC0.
read16 (DEFAULT_RCBA + 0x2026); // !!! = 0x0000 */
read16 (DEFAULT_RCBA + 0x2036); // !!! = 0x0000
read16 (DEFAULT_RCBA + 0x2046); // !!! = 0x0000 RCBA32(0x2014) = (1 << 31) | (0 << 24) | (0x0c << 1) | 1;
read16 (DEFAULT_DMIBAR + 0x001a); // !!! = 0x0000
read16 (DEFAULT_DMIBAR + 0x0026); // !!! = 0x0000 /* Virtual Channel 1 Resource Control Register.
read16 (DEFAULT_DMIBAR + 0x0032); // !!! = 0x0000 * Enable channel.
read16 (DEFAULT_DMIBAR + 0x003e); // !!! = 0x0000 * Set Virtual Channel Identifier.
* Map TC1 and TC5 to VC1.
*/
RCBA32(0x2020) = (1 << 31) | (1 << 24) | (0x11 << 1);
/* Read back register */
tmp = RCBA32(0x2020);
/* Virtual Channel private Resource Control Register.
* Enable channel.
* Set Virtual Channel Identifier.
* Map TC2 and TC6 to VCp.
*/
RCBA32(0x2030) = (1 << 31) | (2 << 24) | (0x22 << 1);
/* Read back register */
tmp = RCBA32(0x2030);
/* Virtual Channel ME Resource Control Register.
* Enable channel.
* Set Virtual Channel Identifier.
* Map TC7 to VCm.
*/
RCBA32(0x2040) = (1 << 31) | (7 << 24) | (0x40 << 1);
/* Lock Virtual Channel Resource control register. */
RCBA32(0x0050) |= 0x80000000;
/* Read back register */
tmp = RCBA32(0x0050);
/* Wait for virtual channels negotiation pending */
while (RCBA16(0x201a) & VCNEGPND)
;
while (RCBA16(0x2026) & VCNEGPND)
;
while (RCBA16(0x2036) & VCNEGPND)
;
while (RCBA16(0x2046) & VCNEGPND)
;
/*
* BIOS Requirement: Check if DMI VC Negotiation was successful.
* Wait for virtual channels negotiation pending.
*/
while (DMIBAR16(DMIVC0RSTS) & VC0NP)
;
while (DMIBAR16(DMIVC1RSTS) & VC1NP)
;
while (DMIBAR16(DMIVCPRSTS) & VCPNP)
;
while (DMIBAR16(DMIVCMRSTS) & VCMNP)
;
} }
void void

View File

@ -310,6 +310,8 @@ early_usb_init (const struct southbridge_usb_port *portmap);
#define IOTR2 0x1e90 /* 64bit */ #define IOTR2 0x1e90 /* 64bit */
#define IOTR3 0x1e98 /* 64bit */ #define IOTR3 0x1e98 /* 64bit */
#define VCNEGPND 2
#define TCTL 0x3000 /* 8bit */ #define TCTL 0x3000 /* 8bit */
#define NOINT 0 #define NOINT 0