mb/google/zork: rename baseboard GPIO table getter for clarity

Rename variant_pcie_gpio_table() to baseboard_pcie_gpio_table(), since
the GPIO table comes from the baseboard (and is not overridden by any
variant).

Drop the __weak qualifier as this function is not overridden.

This is similar to the change made for skyrim in CB:67809

Change-Id: Idd8ea3446ab7940b21265a3ed8080ba4029c4ff7
Signed-off-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/69453
Reviewed-by: Martin Roth <martin.roth@amd.corp-partner.google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
Matt DeVillier 2022-11-11 10:56:07 -06:00 committed by Martin L Roth
parent c3583173ec
commit bfad0b0651
4 changed files with 5 additions and 5 deletions

View File

@ -12,5 +12,5 @@ void bootblock_mainboard_early_init(void)
gpios = variant_bootblock_gpio_table(&num_gpios, acpi_get_sleep_type()); gpios = variant_bootblock_gpio_table(&num_gpios, acpi_get_sleep_type());
gpio_configure_pads(gpios, num_gpios); gpio_configure_pads(gpios, num_gpios);
variant_pcie_gpio_configure(); baseboard_pcie_gpio_configure();
} }

View File

@ -248,7 +248,7 @@ static void wifi_power_reset_configure_pre_v3(void)
gpio_set(GPIO_42, 1); gpio_set(GPIO_42, 1);
} }
__weak void variant_pcie_gpio_configure(void) void baseboard_pcie_gpio_configure(void)
{ {
static const struct soc_amd_gpio pcie_gpio_table[] = { static const struct soc_amd_gpio pcie_gpio_table[] = {
/* PCIE_RST1_L - Variable timings (May remove) */ /* PCIE_RST1_L - Variable timings (May remove) */

View File

@ -258,7 +258,7 @@ static void wifi_power_reset_configure_pre_v3(void)
gpio_set(GPIO_42, 1); gpio_set(GPIO_42, 1);
} }
__weak void variant_pcie_gpio_configure(void) void baseboard_pcie_gpio_configure(void)
{ {
static const struct soc_amd_gpio pcie_gpio_table[] = { static const struct soc_amd_gpio pcie_gpio_table[] = {
/* NVME_AUX_RESET_L */ /* NVME_AUX_RESET_L */

View File

@ -47,8 +47,8 @@ void variant_audio_update(void);
void variant_bluetooth_update(void); void variant_bluetooth_update(void);
/* Update touchscreen configuration in devicetree during ramstage. */ /* Update touchscreen configuration in devicetree during ramstage. */
void variant_touchscreen_update(void); void variant_touchscreen_update(void);
/* Configure PCIe GPIOs as per variant sequencing requirements. */ /* Configure PCIe GPIOs as per baseboard sequencing requirements. */
void variant_pcie_gpio_configure(void); void baseboard_pcie_gpio_configure(void);
/* Per variant FSP-S initialization, default implementation in baseboard and /* Per variant FSP-S initialization, default implementation in baseboard and
* overridable by the variant. */ * overridable by the variant. */