mb/google/octopus: Enable pull on ESPI_IO1 line
This change configures a weak internal pull-up on ESPI_IO1 line for octopus baseboard and variant bip. ESPI_IO1 is used as ALERT# line and is expected to be open-drain. However, there is no external pull on this line and so an internal pull-up is required to ensure proper eSPI communication. BUG=b:78497502 TEST=Verified that there is no eSPI communication failure between AP and EC during boot-up and on suspend/resume. Change-Id: Ic494aa7397b94bfd233ce10da8287660997b3377 Signed-off-by: Furquan Shaikh <furquan@google.com> Reviewed-on: https://review.coreboot.org/25900 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Aaron Durbin <adurbin@chromium.org> Reviewed-by: Justin TerAvest <teravest@chromium.org> Reviewed-by: Hannah Williams <hannah.williams@intel.com>
This commit is contained in:
parent
a2faac2168
commit
c0451791bf
|
@ -279,6 +279,14 @@ static const struct pad_config early_gpio_table[] = {
|
|||
/* Enable power to wifi early in bootblock and de-assert PERST#. */
|
||||
PAD_CFG_GPO(GPIO_178, 1, DEEP), /* EN_PP3300_WLAN */
|
||||
PAD_CFG_GPO(GPIO_164, 0, DEEP), /* WLAN_PE_RST */
|
||||
|
||||
/*
|
||||
* ESPI_IO1 acts as ALERT# (which is open-drain) and requies a weak
|
||||
* pull-up for proper operation. Since there is no external pull present
|
||||
* on this platform, configure an internal weak pull-up.
|
||||
*/
|
||||
PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_151, UP_20K, DEEP, NF2, HIZCRx1,
|
||||
ENPU), /* ESPI_IO1 */
|
||||
};
|
||||
|
||||
const struct pad_config *__weak
|
||||
|
|
|
@ -278,6 +278,14 @@ static const struct pad_config early_gpio_table[] = {
|
|||
/* Enable power to wifi early in bootblock and de-assert PERST#. */
|
||||
PAD_CFG_GPO(GPIO_178, 1, DEEP), /* EN_PP3300_WLAN */
|
||||
PAD_CFG_GPO(GPIO_164, 0, DEEP), /* WLAN_PE_RST */
|
||||
|
||||
/*
|
||||
* ESPI_IO1 acts as ALERT# (which is open-drain) and requies a weak
|
||||
* pull-up for proper operation. Since there is no external pull present
|
||||
* on this platform, configure an internal weak pull-up.
|
||||
*/
|
||||
PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_151, UP_20K, DEEP, NF2, HIZCRx1,
|
||||
ENPU), /* ESPI_IO1 */
|
||||
};
|
||||
|
||||
const struct pad_config *variant_early_gpio_table(size_t *num)
|
||||
|
|
Loading…
Reference in New Issue