From c04d3ddbaef84746e6651e7354a81b874dbd3385 Mon Sep 17 00:00:00 2001 From: Felix Held Date: Mon, 17 Jul 2023 22:59:02 +0200 Subject: [PATCH] include/cpu/amd/msr: introduce and use PSTATE_MSR_COUNT Add and use a define for the total number of P-state MSRs to avoid magic constants in the code. Signed-off-by: Felix Held Change-Id: I37a89faa0f216790b3404fc03edc62408684cc24 Reviewed-on: https://review.coreboot.org/c/coreboot/+/76546 Tested-by: build bot (Jenkins) Reviewed-by: Elyes Haouas --- src/include/cpu/amd/msr.h | 1 + src/soc/amd/stoneyridge/pstate_util.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/include/cpu/amd/msr.h b/src/include/cpu/amd/msr.h index ccc9719cb6..3f7febc462 100644 --- a/src/include/cpu/amd/msr.h +++ b/src/include/cpu/amd/msr.h @@ -41,6 +41,7 @@ #define PS_STS_REG 0xC0010063 #define PSTATE_0_MSR 0xC0010064 #define PSTATE_MSR(pstate) (PSTATE_0_MSR + (pstate)) +#define PSTATE_MSR_COUNT 8 #define MSR_PATCH_LOADER 0xC0010020 diff --git a/src/soc/amd/stoneyridge/pstate_util.c b/src/soc/amd/stoneyridge/pstate_util.c index 12bc2b5cfa..cd5878f82a 100644 --- a/src/soc/amd/stoneyridge/pstate_util.c +++ b/src/soc/amd/stoneyridge/pstate_util.c @@ -21,7 +21,7 @@ static bool all_pstates_have_same_frequency_id(void) bool first = true; uint32_t frequency_id; - for (i = 0; i < 8; i++) { + for (i = 0; i < PSTATE_MSR_COUNT; i++) { pstate_reg.raw = rdmsr(PSTATE_MSR(i)).raw; if (!pstate_reg.pstate_en)