GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/rex: Fix ISH I2C pad for suspend 

During suspend, the ISH I2C transactions cannot go through
because the GPIO pads remain the pervious value.
The IO Standby State (IOSSTATE) needs to be changed to keep I2C bus
active and functional during suspend.

BUG=b:302612549
TEST=on Google/rex platform with ISH enabled, do suspend_stress_test
and check that no i2c failure.

Signed-off-by: Cliff Huang <cliff.huang@intel.com>
Change-Id: I9a2c902ed56461f3a535428db399c2050756f2da
Reviewed-on: https://review.coreboot.org/c/coreboot/+/78179
Reviewed-by: Subrata Banik <subratabanik@google.com>
Reviewed-by: Li1 Feng <li1.feng@intel.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Cliff Huang 2023-09-29 00:12:51 -07:00 committed by Subrata Banik
parent 3aa7bb0d32
commit c0d0aecf16
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/mainboard/google/rex/variants/rex0/fw_config.c
View File

@ -85,9 +85,9 @@ static const struct pad_config bt_i2s_disable_pads[] = {
static const struct pad_config ish_enable_pads[] = { static const struct pad_config ish_enable_pads[] = {
/* GPP_B02 : ISH I2C0_SDA */ /* GPP_B02 : ISH I2C0_SDA */
PAD_CFG_NF(GPP_B02, NONE, DEEP, NF3), PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_B02, NONE, DEEP, NF3),
/* GPP_B03 : ISH_I2C0_SCL */ /* GPP_B03 : ISH_I2C0_SCL */
PAD_CFG_NF(GPP_B03, NONE, DEEP, NF3), PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_B03, NONE, DEEP, NF3),
/* GPP_D05 : ISH_UART_TX */ /* GPP_D05 : ISH_UART_TX */
PAD_CFG_NF(GPP_D05, NONE, DEEP, NF2), PAD_CFG_NF(GPP_D05, NONE, DEEP, NF2),
/* GPP_D06 : ISH_UART_RX */ /* GPP_D06 : ISH_UART_RX */