GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

device/resource_allocator_v4: Change BIOS_SPEW to BIOS_DEBUG 

This change updates the log level for prints in resource allocator v4
to BIOS_DEBUG instead of BIOS_SPEW. These are critical in debugging
issues and should be enabled at log level BIOS_DEBUG.

Signed-off-by: Furquan Shaikh <furquan@google.com>
Change-Id: Ib863619f5e1214e4fe6f05c52be6fa2de36e6c3b
Reviewed-on: https://review.coreboot.org/c/coreboot/+/41477
Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Furquan Shaikh 2020-05-16 13:54:37 -07:00 committed by Patrick Georgi
parent 918ee62977
commit c0dc1e1bbe
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/device/resource_allocator_v4.c
View File

@ -67,7 +67,7 @@ static void update_bridge_resource(const struct device *bridge, struct resource
*/ */
base = 0; base = 0;
printk(BIOS_SPEW, "%s %s: size: %llx align: %d gran: %d limit: %llx\n", printk(BIOS_DEBUG, "%s %s: size: %llx align: %d gran: %d limit: %llx\n",
dev_path(bridge), resource2str(bridge_res), bridge_res->size, dev_path(bridge), resource2str(bridge_res), bridge_res->size,
bridge_res->align, bridge_res->gran, bridge_res->limit); bridge_res->align, bridge_res->gran, bridge_res->limit);
@ -122,7 +122,7 @@ static void update_bridge_resource(const struct device *bridge, struct resource
*/ */
base = round(base, child_res->align); base = round(base, child_res->align);
printk(BIOS_SPEW, "%s %02lx * [0x%llx - 0x%llx] %s\n", printk(BIOS_DEBUG, "%s %02lx * [0x%llx - 0x%llx] %s\n",
dev_path(child), child_res->index, base, base + child_res->size - 1, dev_path(child), child_res->index, base, base + child_res->size - 1,
resource2str(child_res)); resource2str(child_res));
@ -137,7 +137,7 @@ static void update_bridge_resource(const struct device *bridge, struct resource
*/ */
bridge_res->size = round(base, bridge_res->gran); bridge_res->size = round(base, bridge_res->gran);
printk(BIOS_SPEW, "%s %s: size: %llx align: %d gran: %d limit: %llx done\n", printk(BIOS_DEBUG, "%s %s: size: %llx align: %d gran: %d limit: %llx done\n",
dev_path(bridge), resource2str(bridge_res), bridge_res->size, dev_path(bridge), resource2str(bridge_res), bridge_res->size,
bridge_res->align, bridge_res->gran, bridge_res->limit); bridge_res->align, bridge_res->gran, bridge_res->limit);
} }
@ -371,7 +371,7 @@ static void allocate_child_resources(struct bus *bus, struct memranges *ranges,
if (memranges_steal(ranges, resource->limit, resource->size, resource->align, if (memranges_steal(ranges, resource->limit, resource->size, resource->align,
type_match, &resource->base) == false) { type_match, &resource->base) == false) {
printk(BIOS_ERR, "ERROR: Resource didn't fit!!! "); printk(BIOS_ERR, "ERROR: Resource didn't fit!!! ");
printk(BIOS_SPEW, "%s %02lx * size: 0x%llx limit: %llx %s\n", printk(BIOS_DEBUG, "%s %02lx * size: 0x%llx limit: %llx %s\n",
dev_path(dev), resource->index, dev_path(dev), resource->index,
resource->size, resource->limit, resource2str(resource)); resource->size, resource->limit, resource2str(resource));
continue; continue;
@ -380,7 +380,7 @@ static void allocate_child_resources(struct bus *bus, struct memranges *ranges,
resource->limit = resource->base + resource->size - 1; resource->limit = resource->base + resource->size - 1;
resource->flags |= IORESOURCE_ASSIGNED; resource->flags |= IORESOURCE_ASSIGNED;
printk(BIOS_SPEW, "%s %02lx * [0x%llx - 0x%llx] limit: %llx %s\n", printk(BIOS_DEBUG, "%s %02lx * [0x%llx - 0x%llx] limit: %llx %s\n",
dev_path(dev), resource->index, resource->base, dev_path(dev), resource->index, resource->base,
resource->size ? resource->base + resource->size - 1 : resource->size ? resource->base + resource->size - 1 :
resource->base, resource->limit, resource2str(resource)); resource->base, resource->limit, resource2str(resource));
@ -393,7 +393,7 @@ static void update_constraints(struct memranges *ranges, const struct device *de
if (!res->size) if (!res->size)
return; return;
printk(BIOS_SPEW, "%s: %s %02lx base %08llx limit %08llx %s (fixed)\n", printk(BIOS_DEBUG, "%s: %s %02lx base %08llx limit %08llx %s (fixed)\n",
__func__, dev_path(dev), res->index, res->base, __func__, dev_path(dev), res->index, res->base,
res->base + res->size - 1, resource2str(res)); res->base + res->size - 1, resource2str(res));
@ -466,7 +466,7 @@ static void constrain_domain_resources(const struct device *domain, struct memra
static void setup_resource_ranges(const struct device *dev, const struct resource *res, static void setup_resource_ranges(const struct device *dev, const struct resource *res,
unsigned long type, struct memranges *ranges) unsigned long type, struct memranges *ranges)
{ {
printk(BIOS_SPEW, "%s %s: base: %llx size: %llx align: %d gran: %d limit: %llx\n", printk(BIOS_DEBUG, "%s %s: base: %llx size: %llx align: %d gran: %d limit: %llx\n",
dev_path(dev), resource2str(res), res->base, res->size, res->align, dev_path(dev), resource2str(res), res->base, res->size, res->align,
res->gran, res->limit); res->gran, res->limit);
@ -484,7 +484,7 @@ static void cleanup_resource_ranges(const struct device *dev, struct memranges *
const struct resource *res) const struct resource *res)
{ {
memranges_teardown(ranges); memranges_teardown(ranges);
printk(BIOS_SPEW, "%s %s: base: %llx size: %llx align: %d gran: %d limit: %llx done\n", printk(BIOS_DEBUG, "%s %s: base: %llx size: %llx align: %d gran: %d limit: %llx done\n",
dev_path(dev), resource2str(res), res->base, res->size, res->align, dev_path(dev), resource2str(res), res->base, res->size, res->align,
res->gran, res->limit); res->gran, res->limit);
} }