GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

dmp/vortex86ex/southbridge.c: Do not access arrays out of bound 

Found by Cppcheck 1.65. Fixes:
[src/southbridge/dmp/vortex86ex/southbridge.c:498]: (error) Array 'rtc[7]' accessed at index 7, which is out of bounds.
[src/southbridge/dmp/vortex86ex/southbridge.c:498]: (error) Array 'bin_rtc[7]' accessed at index 7, which is out of bounds.

Change-Id: I8939fe1b326202bbe2784639b0e591f8ee470eeb
Signed-off-by: Daniele Forsi <dforsi@gmail.com>
Reviewed-on: http://review.coreboot.org/6375
Tested-by: build bot (Jenkins)
Reviewed-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
Reviewed-by: Andrew Wu <arw@dmp.com.tw>
This commit is contained in:
Daniele Forsi 2014-07-26 11:17:03 +02:00 committed by Edward O'Callaghan
parent f8e96f07d4
commit c2519e5a06
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/southbridge/dmp/vortex86ex/southbridge.c
View File

@ -494,7 +494,7 @@ static void fix_cmos_rtc_time(void)
/* Convert RTC from BCD format to binary. */
u8 bin_rtc[7];
int i;
for (i = 0; i < 8; i++) {
for (i = 0; i < 7; i++) {
bin_rtc[i] = bcd2dec(rtc[i]);
}