From c2f1202151208a35dea7c5fec1de2192752ff900 Mon Sep 17 00:00:00 2001 From: Elyes HAOUAS Date: Fri, 7 Jan 2022 19:05:11 +0100 Subject: [PATCH] security/intel/txt/common.c: Remove unuseful "else" after "return" "else" is unuseful after a "break" or "return". Change-Id: I7273b9af46a2310c9981ffd20afe2c8c7e061479 Signed-off-by: Elyes Haouas Reviewed-on: https://review.coreboot.org/c/coreboot/+/60910 Reviewed-by: Paul Menzel Tested-by: build bot (Jenkins) Reviewed-by: Felix Singer --- src/security/intel/txt/common.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/src/security/intel/txt/common.c b/src/security/intel/txt/common.c index ea348d2c43..b88062d42b 100644 --- a/src/security/intel/txt/common.c +++ b/src/security/intel/txt/common.c @@ -489,15 +489,14 @@ bool intel_txt_prepare_txt_env(void) failure = true; } - if (!getsec_parameter(NULL, NULL, NULL, NULL, NULL, &txt_feature_flags)) { + if (!getsec_parameter(NULL, NULL, NULL, NULL, NULL, &txt_feature_flags)) return true; - } else { - printk(BIOS_DEBUG, "TEE-TXT: Machine Check Register: "); - if (txt_feature_flags & GETSEC_PARAMS_TXT_EXT_MACHINE_CHECK) - printk(BIOS_DEBUG, "preserved\n"); - else - printk(BIOS_DEBUG, "must be clear\n"); - } + + printk(BIOS_DEBUG, "TEE-TXT: Machine Check Register: "); + if (txt_feature_flags & GETSEC_PARAMS_TXT_EXT_MACHINE_CHECK) + printk(BIOS_DEBUG, "preserved\n"); + else + printk(BIOS_DEBUG, "must be clear\n"); if (!(txt_feature_flags & GETSEC_PARAMS_TXT_EXT_MACHINE_CHECK)) { /*