GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd/picasso: use SMBus timeout in compilation unit 

The timeout is fixed and only used in one place. Put the assumption
in the compliation unit utilizing the defintion.

Change-Id: I93c061e74df6b4265fd1c61fc4669410ebc9554f
Signed-off-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/38614
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
Aaron Durbin 2020-01-28 11:00:51 -07:00
parent 3bee7df954
commit c3488988b8
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/soc/amd/picasso/include/soc/smbus.h
View File

@ -19,12 +19,6 @@
#include <stdint.h> #include <stdint.h>
#include <soc/iomap.h> #include <soc/iomap.h>
/*
* Between 1-10 seconds, We should never timeout normally
* Longer than this is just painful when a timeout condition occurs.
*/
#define SMBUS_TIMEOUT (100 * 1000 * 10)
int do_smbus_read_byte(u32 mmio, u8 device, u8 address); int do_smbus_read_byte(u32 mmio, u8 device, u8 address);
int do_smbus_write_byte(u32 mmio, u8 device, u8 address, u8 val); int do_smbus_write_byte(u32 mmio, u8 device, u8 address, u8 val);
int do_smbus_recv_byte(u32 mmio, u8 device); int do_smbus_recv_byte(u32 mmio, u8 device);

6
src/soc/amd/picasso/smbus.c
View File

@ -19,6 +19,12 @@
#include <soc/smbus.h> #include <soc/smbus.h>
#include <soc/southbridge.h> #include <soc/southbridge.h>
/*
* Between 1-10 seconds, We should never timeout normally
* Longer than this is just painful when a timeout condition occurs.
*/
#define SMBUS_TIMEOUT (100 * 1000 * 10)
static u8 controller_read8(u32 base, u8 reg) static u8 controller_read8(u32 base, u8 reg)
{ {
switch (base) { switch (base) {